You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/19 08:36:56 UTC
[GitHub] [spark] LuciferYang opened a new pull request #32230: [SPARK-35134][TEST] Manually exclude redundant netty jars in SparkBuild.scala
LuciferYang opened a new pull request #32230:
URL: https://github.com/apache/spark/pull/32230
### What changes were proposed in this pull request?
The following logs will print when Jenkins execute `PySpark pip packaging tests`:
```
copying deps/jars/netty-all-4.1.51.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-buffer-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-codec-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-common-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-handler-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-resolver-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-transport-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-transport-native-epoll-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
```
There will be 2 different versions of netty4 jars copied to the jars directory, but the `netty-xxx-4.1.50.Final.jar` not in maven `dependency:tree `, but spark only needs to rely on `netty-all-xxx.jar`.
So this pr try to add new `ExclusionRule`s to `SparkBuild.scala` to exclude unnecessary netty 4 dependencies.
### Why are the changes needed?
Make sure that only `netty-all-xxx.jar` is used in the test to avoid possible jar conflicts.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Pass the Jenkins or GitHub Action
- Check Jenkins log manually, there should be no such logs as
```
copying deps/jars/netty-buffer-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-codec-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-common-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-handler-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-resolver-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-transport-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
copying deps/jars/netty-transport-native-epoll-4.1.50.Final.jar -> pyspark-3.2.0.dev0/deps/jars
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32230: [SPARK-35134][BUILD][TEST] Manually exclude redundant netty jars in SparkBuild.scala
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-822377816
**[Test build #137617 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137617/testReport)** for PR 32230 at commit [`0032e0f`](https://github.com/apache/spark/commit/0032e0f1d21e9c65e289c2635edb6648630b8faa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32230: [SPARK-35134][BUILD][TEST] Manually exclude redundant netty jars in SparkBuild.scala
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-822521065
**[Test build #137617 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137617/testReport)** for PR 32230 at commit [`0032e0f`](https://github.com/apache/spark/commit/0032e0f1d21e9c65e289c2635edb6648630b8faa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32230: [SPARK-35134][BUILD][TESTS] Manually exclude redundant netty jars in SparkBuild.scala to avoid version conflicts in test
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32230:
URL: https://github.com/apache/spark/pull/32230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32230: [SPARK-35134][BUILD][TESTS] Manually exclude redundant netty jars in SparkBuild.scala to avoid version conflicts in test
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-822987980
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #32230: [SPARK-35134][BUILD][TEST] Manually exclude redundant netty jars in SparkBuild.scala
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-822923200
[https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137617/testReport](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137617/testReport)
[https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137629/testReport](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137629/testReport)
Manually exclude `netty-handler` and `netty-transport-native-epoll`, It looks like only `netty-all-xxx.jar` has been copied, there should be no more version conflicts with netty
@HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32230: [SPARK-35134][BUILD][TEST] Manually exclude redundant netty jars in SparkBuild.scala
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-822377816
**[Test build #137617 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137617/testReport)** for PR 32230 at commit [`0032e0f`](https://github.com/apache/spark/commit/0032e0f1d21e9c65e289c2635edb6648630b8faa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32230: [SPARK-35134][BUILD][TEST] Manually exclude redundant netty jars in SparkBuild.scala
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-822342668
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42148/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32230: [SPARK-35134][BUILD][TEST] Manually exclude redundant netty jars in SparkBuild.scala
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-822534422
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137617/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32230: [SPARK-35134][BUILD][TEST] Manually exclude redundant netty jars in SparkBuild.scala
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-822534422
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137617/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32230: [SPARK-35134][BUILD][TEST] Manually exclude redundant netty jars in SparkBuild.scala
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-822342617
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42148/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32230: [SPARK-35134][BUILD][TEST] Manually exclude redundant netty jars in SparkBuild.scala
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-822342668
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42148/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #32230: [SPARK-35134][BUILD][TEST] Manually exclude redundant netty jars in SparkBuild.scala
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-822923200
Manually exclude `netty-handler` and `netty-transport-native-epoll`, It looks like only `netty-all-xxx.jar` has been copied, there should be no more version conflicts with netty
@HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #32230: [SPARK-35134][BUILD][TESTS] Manually exclude redundant netty jars in SparkBuild.scala to avoid version conflicts in test
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #32230:
URL: https://github.com/apache/spark/pull/32230#issuecomment-823002836
thx ~ @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org