You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/01 12:27:06 UTC

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #3269: Add support for motor debug messages

raiden00pl opened a new pull request #3269:
URL: https://github.com/apache/incubator-nuttx/pull/3269


   ## Summary
   Add support for motor debug messages and use them in all FOC files.
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #3269: Add support for motor debug messages

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3269:
URL: https://github.com/apache/incubator-nuttx/pull/3269#issuecomment-811908987


   @raiden00pl I noticed there are two motors entry inside Device Drivers one in the middle and other in the bottom:
   
   [ ] Motor driver
   [ ] Motor control drivers  ----
   
   Suggestion: merge both and keep it in the middle ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3269: Add support for motor debug messages

Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #3269:
URL: https://github.com/apache/incubator-nuttx/pull/3269#issuecomment-811908987


   @raiden00pl I noticed there are two motors entries inside Device Drivers one in the middle and other in the bottom:
   
   [ ] Motor driver
   [ ] Motor control drivers  ----
   
   Suggestion: merge both and keep it in the middle ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] raiden00pl commented on pull request #3269: Add support for motor debug messages

Posted by GitBox <gi...@apache.org>.
raiden00pl commented on pull request #3269:
URL: https://github.com/apache/incubator-nuttx/pull/3269#issuecomment-812340749


   I'll move motor.c to drivers/motor later. At this moment I want to finish support for FOC.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3269: Add support for motor debug messages

Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #3269:
URL: https://github.com/apache/incubator-nuttx/pull/3269#issuecomment-811908987


   @raiden00pl I noticed there are two motors entries inside Device Drivers one at the middle and other at the bottom:
   
   [ ] Motor driver
   [ ] Motor control drivers  ----
   
   Suggestion: merge both and keep it in the middle ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #3269: Add support for motor debug messages

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #3269:
URL: https://github.com/apache/incubator-nuttx/pull/3269


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #3269: Add support for motor debug messages

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3269:
URL: https://github.com/apache/incubator-nuttx/pull/3269#issuecomment-811910209


   > @raiden00pl I noticed there are two motors entries inside Device Drivers one at the middle and other at the bottom:
   > 
   > [ ] Motor driver
   > [ ] Motor control drivers ----
   > 
   > Suggestion: merge both and keep it in the middle ;-)
   
   Yes, ideally we should make motor.c also use these defines and organize both files inside same directory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org