You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/10 02:13:16 UTC

[GitHub] [incubator-dolphinscheduler] gabrywu opened a new pull request #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

gabrywu opened a new pull request #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922
 
 
   Adapting partial code(file name start with D) to the sonar cloud rule,part 1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922#issuecomment-585059591
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25.png' alt='35.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_coverage&view=list) [35.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='1.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_duplicated_lines_density&view=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922#issuecomment-583929923
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25.png' alt='35.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_coverage&view=list) [35.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5.png' alt='3.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_duplicated_lines_density&view=list) [3.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922#discussion_r378171568
 
 

 ##########
 File path: dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/job/db/DB2ServerDataSourceTest.java
 ##########
 @@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.common.job.db;
+
+import org.apache.dolphinscheduler.common.enums.DbType;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class DB2ServerDataSourceTest {
+    @Test
+    public void getJdbcUrl(){
+        BaseDataSource db2Ds = DataSourceFactory.getDatasource(DbType.DB2,
+                "{\"user\":\"user\",\"password\":\"xxx\"," +
+                        "\"address\":\"db2host\",\"database\":\"db\",\"other\":\"otherPara\"}");
+        Assert.assertTrue(db2Ds instanceof DB2ServerDataSource);
+        DB2ServerDataSource db2ServerDataSource = (DB2ServerDataSource) db2Ds;
+        Assert.assertEquals("db2host/db:otherPara",db2ServerDataSource.getJdbcUrl());
+        try {
+            db2ServerDataSource.isConnectable();
+            Assert.fail("db2 data source can not be connected");
 
 Review comment:
   why assert like this ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922#issuecomment-583929923
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25.png' alt='35.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_coverage&view=list) [35.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5.png' alt='3.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_duplicated_lines_density&view=list) [3.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922#issuecomment-585057353
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25.png' alt='35.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_coverage&view=list) [35.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='1.8%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_duplicated_lines_density&view=list) [1.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922#issuecomment-583929496
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=h1) Report
   > Merging [#1922](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/b77dddfeefa87be2027c5ddac29350f946b9e629?src=pr&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `28.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev    #1922      +/-   ##
   ==========================================
   - Coverage   24.88%   24.84%   -0.04%     
   ==========================================
     Files         298      298              
     Lines       14387    14387              
     Branches     2371     2370       -1     
   ==========================================
   - Hits         3580     3575       -5     
   - Misses      10358    10364       +6     
   + Partials      449      448       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...inscheduler/common/job/db/DB2ServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9EQjJTZXJ2ZXJEYXRhU291cmNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...g/apache/dolphinscheduler/dao/utils/DagHelper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL0RhZ0hlbHBlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...heduler/api/controller/DataAnalysisController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YUFuYWx5c2lzQ29udHJvbGxlci5qYXZh) | `2.77% <0%> (ø)` | :arrow_up: |
   | [.../org/apache/dolphinscheduler/common/graph/DAG.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2dyYXBoL0RBRy5qYXZh) | `87.68% <66.66%> (-0.18%)` | :arrow_down: |
   | [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `40.5% <0%> (-2%)` | :arrow_down: |
   | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `57.14% <0%> (+14.28%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=footer). Last update [b77dddf...295dfa4](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922#issuecomment-583929496
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=h1) Report
   > Merging [#1922](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/b77dddfeefa87be2027c5ddac29350f946b9e629?src=pr&el=desc) will **increase** coverage by `1.45%`.
   > The diff coverage is `28.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #1922      +/-   ##
   ============================================
   + Coverage     24.89%   26.34%   +1.45%     
   - Complexity        0     1347    +1347     
   ============================================
     Files           298      312      +14     
     Lines         14387    16641    +2254     
     Branches       2371     2047     -324     
   ============================================
   + Hits           3581     4384     +803     
   - Misses        10357    11786    +1429     
   - Partials        449      471      +22
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/common/job/db/DB2ServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9EQjJTZXJ2ZXJEYXRhU291cmNlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/dolphinscheduler/dao/utils/DagHelper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL0RhZ0hlbHBlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...heduler/api/controller/DataAnalysisController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YUFuYWx5c2lzQ29udHJvbGxlci5qYXZh) | `5.4% <0%> (+2.62%)` | `2 <0> (+2)` | :arrow_up: |
   | [.../org/apache/dolphinscheduler/common/graph/DAG.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2dyYXBoL0RBRy5qYXZh) | `95.96% <66.66%> (+8.11%)` | `41 <0> (+41)` | :arrow_up: |
   | [...dolphinscheduler/common/utils/EncryptionUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0VuY3J5cHRpb25VdGlscy5qYXZh) | `50% <0%> (-50%)` | `2% <0%> (+2%)` | |
   | [...lphinscheduler/common/utils/SensitiveLogUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWxzLmphdmE=) | `75% <0%> (-25%)` | `2% <0%> (+2%)` | |
   | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | `2% <0%> (+2%)` | |
   | [.../api/utils/exportprocess/TaskNodeParamFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL2V4cG9ydHByb2Nlc3MvVGFza05vZGVQYXJhbUZhY3RvcnkuamF2YQ==) | `66.66% <0%> (-13.34%)` | `3% <0%> (+3%)` | |
   | [...apache/dolphinscheduler/common/thread/Stopper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9TdG9wcGVyLmphdmE=) | `66.66% <0%> (-13.34%)` | `4% <0%> (+4%)` | |
   | [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0% <0%> (-13.12%)` | `0% <0%> (ø)` | |
   | ... and [275 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=footer). Last update [b77dddf...f025770](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922#issuecomment-583929496
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=h1) Report
   > Merging [#1922](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/b77dddfeefa87be2027c5ddac29350f946b9e629?src=pr&el=desc) will **increase** coverage by `1.45%`.
   > The diff coverage is `28.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #1922      +/-   ##
   ============================================
   + Coverage     24.89%   26.34%   +1.45%     
   - Complexity        0     1347    +1347     
   ============================================
     Files           298      312      +14     
     Lines         14387    16641    +2254     
     Branches       2371     2047     -324     
   ============================================
   + Hits           3581     4384     +803     
   - Misses        10357    11786    +1429     
   - Partials        449      471      +22
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/common/job/db/DB2ServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9EQjJTZXJ2ZXJEYXRhU291cmNlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/dolphinscheduler/dao/utils/DagHelper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL0RhZ0hlbHBlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...heduler/api/controller/DataAnalysisController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YUFuYWx5c2lzQ29udHJvbGxlci5qYXZh) | `5.4% <0%> (+2.62%)` | `2 <0> (+2)` | :arrow_up: |
   | [.../org/apache/dolphinscheduler/common/graph/DAG.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2dyYXBoL0RBRy5qYXZh) | `95.96% <66.66%> (+8.11%)` | `41 <0> (+41)` | :arrow_up: |
   | [...dolphinscheduler/common/utils/EncryptionUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0VuY3J5cHRpb25VdGlscy5qYXZh) | `50% <0%> (-50%)` | `2% <0%> (+2%)` | |
   | [...lphinscheduler/common/utils/SensitiveLogUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWxzLmphdmE=) | `75% <0%> (-25%)` | `2% <0%> (+2%)` | |
   | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | `2% <0%> (+2%)` | |
   | [.../api/utils/exportprocess/TaskNodeParamFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL2V4cG9ydHByb2Nlc3MvVGFza05vZGVQYXJhbUZhY3RvcnkuamF2YQ==) | `66.66% <0%> (-13.34%)` | `3% <0%> (+3%)` | |
   | [...apache/dolphinscheduler/common/thread/Stopper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9TdG9wcGVyLmphdmE=) | `66.66% <0%> (-13.34%)` | `4% <0%> (+4%)` | |
   | [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0% <0%> (-13.12%)` | `0% <0%> (ø)` | |
   | ... and [275 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=footer). Last update [b77dddf...f025770](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922#issuecomment-583929496
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=h1) Report
   > Merging [#1922](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/b77dddfeefa87be2027c5ddac29350f946b9e629?src=pr&el=desc) will **increase** coverage by `1.8%`.
   > The diff coverage is `28.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##                dev    #1922     +/-   ##
   ===========================================
   + Coverage     24.89%   26.69%   +1.8%     
   - Complexity        0     1347   +1347     
   ===========================================
     Files           298      313     +15     
     Lines         14387    17042   +2655     
     Branches       2371     2199    -172     
   ===========================================
   + Hits           3581     4549    +968     
   - Misses        10357    12039   +1682     
   - Partials        449      454      +5
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/common/job/db/DB2ServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9EQjJTZXJ2ZXJEYXRhU291cmNlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...g/apache/dolphinscheduler/dao/utils/DagHelper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL0RhZ0hlbHBlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...heduler/api/controller/DataAnalysisController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvRGF0YUFuYWx5c2lzQ29udHJvbGxlci5qYXZh) | `5.4% <0%> (+2.62%)` | `2 <0> (+2)` | :arrow_up: |
   | [.../org/apache/dolphinscheduler/common/graph/DAG.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2dyYXBoL0RBRy5qYXZh) | `87.68% <66.66%> (-0.18%)` | `41 <0> (+41)` | |
   | [...dolphinscheduler/common/utils/EncryptionUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0VuY3J5cHRpb25VdGlscy5qYXZh) | `50% <0%> (-50%)` | `2% <0%> (+2%)` | |
   | [...lphinscheduler/common/utils/SensitiveLogUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWxzLmphdmE=) | `75% <0%> (-25%)` | `2% <0%> (+2%)` | |
   | [.../api/utils/exportprocess/TaskNodeParamFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL2V4cG9ydHByb2Nlc3MvVGFza05vZGVQYXJhbUZhY3RvcnkuamF2YQ==) | `66.66% <0%> (-13.34%)` | `3% <0%> (+3%)` | |
   | [...apache/dolphinscheduler/common/thread/Stopper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9TdG9wcGVyLmphdmE=) | `66.66% <0%> (-13.34%)` | `4% <0%> (+4%)` | |
   | [...che/dolphinscheduler/common/enums/CommandType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0NvbW1hbmRUeXBlLmphdmE=) | `88.88% <0%> (-11.12%)` | `2% <0%> (+2%)` | |
   | [...apache/dolphinscheduler/alert/utils/FuncUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9GdW5jVXRpbHMuamF2YQ==) | `91.66% <0%> (-8.34%)` | `5% <0%> (+5%)` | |
   | ... and [263 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=footer). Last update [b77dddf...f025770](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] gabrywu closed pull request #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

Posted by GitBox <gi...@apache.org>.
gabrywu closed pull request #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule, part 1

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on issue #1922: Adapting partial code(file name start with D) to the sonar cloud rule,part 1
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1922#issuecomment-585057353
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1922&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25.png' alt='35.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_coverage&view=list) [35.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='1.8%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_duplicated_lines_density&view=list) [1.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1922&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services