You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "Akshat-Jain (via GitHub)" <gi...@apache.org> on 2025/04/11 04:45:16 UTC

[PR] Remove JDK matrix for `query` integration tests (druid)

Akshat-Jain opened a new pull request, #17901:
URL: https://github.com/apache/druid/pull/17901

   ### Description
   
   We run the standard ITs against JDK 17, but we had `Dgroups=query` integration tests running on a matrix of JDKs. It doesn't seem intentional, and seems like we just missed removing the JDK matrix for this test as part of https://github.com/apache/druid/pull/13918/files#diff-d5b9dbcc3da61889996a6d61ffbe52ff2407debfdae053a7c0bce2373b09361a.
   
   Hence, this PR removes the JDK matrix and runs the test against JDK 17, similar to other ITs.
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Remove JDK matrix for `query` integration tests (druid)

Posted by "Akshat-Jain (via GitHub)" <gi...@apache.org>.
Akshat-Jain commented on code in PR #17901:
URL: https://github.com/apache/druid/pull/17901#discussion_r2038790763


##########
it.sh:
##########
@@ -23,7 +23,7 @@
 set -e
 
 # Enable for debugging
-#set -x
+set -x

Review Comment:
   Have enabled logging here to debug the other failing integration-test. Will revert this change before merging this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Remove JDK matrix for `query` integration tests (druid)

Posted by "Akshat-Jain (via GitHub)" <gi...@apache.org>.
Akshat-Jain merged PR #17901:
URL: https://github.com/apache/druid/pull/17901


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Remove JDK matrix for `query` integration tests (druid)

Posted by "Akshat-Jain (via GitHub)" <gi...@apache.org>.
Akshat-Jain commented on code in PR #17901:
URL: https://github.com/apache/druid/pull/17901#discussion_r2038830555


##########
it.sh:
##########
@@ -23,7 +23,7 @@
 set -e
 
 # Enable for debugging
-#set -x
+set -x

Review Comment:
   Have reverted that change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org