You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/03/31 22:19:27 UTC
[jira] Created: (HADOOP-6667) RPC.waitForProxy should retry through
NoRouteToHostException
RPC.waitForProxy should retry through NoRouteToHostException
------------------------------------------------------------
Key: HADOOP-6667
URL: https://issues.apache.org/jira/browse/HADOOP-6667
Project: Hadoop Common
Issue Type: Improvement
Components: ipc
Affects Versions: 0.21.0, 0.22.0
Reporter: Todd Lipcon
Priority: Minor
RPC.waitForProxy already loops through ConnectExceptions, but NoRouteToHostException is not a subclass of ConnectException. In the case that the NN is on a VIP, the No Route To Host error is reasonably common during a failover, so we should retry through it just the same as the other connection errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6667) RPC.waitForProxy should retry
through NoRouteToHostException
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852144#action_12852144 ]
Eli Collins commented on HADOOP-6667:
-------------------------------------
+1 lgtm
> RPC.waitForProxy should retry through NoRouteToHostException
> ------------------------------------------------------------
>
> Key: HADOOP-6667
> URL: https://issues.apache.org/jira/browse/HADOOP-6667
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6667.txt
>
>
> RPC.waitForProxy already loops through ConnectExceptions, but NoRouteToHostException is not a subclass of ConnectException. In the case that the NN is on a VIP, the No Route To Host error is reasonably common during a failover, so we should retry through it just the same as the other connection errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6667) RPC.waitForProxy should retry through
NoRouteToHostException
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-6667:
------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
I've just committed this. Thanks Todd!
> RPC.waitForProxy should retry through NoRouteToHostException
> ------------------------------------------------------------
>
> Key: HADOOP-6667
> URL: https://issues.apache.org/jira/browse/HADOOP-6667
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6667.txt
>
>
> RPC.waitForProxy already loops through ConnectExceptions, but NoRouteToHostException is not a subclass of ConnectException. In the case that the NN is on a VIP, the No Route To Host error is reasonably common during a failover, so we should retry through it just the same as the other connection errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6667) RPC.waitForProxy should retry through
NoRouteToHostException
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6667:
--------------------------------
Attachment: hadoop-6667.txt
Trivial patch attached. There's no test case since this is just like the other existing catch clauses, and any test case would just be testing whether catch clauses indeed work :)
> RPC.waitForProxy should retry through NoRouteToHostException
> ------------------------------------------------------------
>
> Key: HADOOP-6667
> URL: https://issues.apache.org/jira/browse/HADOOP-6667
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6667.txt
>
>
> RPC.waitForProxy already loops through ConnectExceptions, but NoRouteToHostException is not a subclass of ConnectException. In the case that the NN is on a VIP, the No Route To Host error is reasonably common during a failover, so we should retry through it just the same as the other connection errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6667) RPC.waitForProxy should retry through
NoRouteToHostException
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6667:
--------------------------------
Assignee: Todd Lipcon
Status: Patch Available (was: Open)
> RPC.waitForProxy should retry through NoRouteToHostException
> ------------------------------------------------------------
>
> Key: HADOOP-6667
> URL: https://issues.apache.org/jira/browse/HADOOP-6667
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6667.txt
>
>
> RPC.waitForProxy already loops through ConnectExceptions, but NoRouteToHostException is not a subclass of ConnectException. In the case that the NN is on a VIP, the No Route To Host error is reasonably common during a failover, so we should retry through it just the same as the other connection errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6667) RPC.waitForProxy should retry
through NoRouteToHostException
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852097#action_12852097 ]
Hadoop QA commented on HADOOP-6667:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12440401/hadoop-6667.txt
against trunk revision 927979.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/435/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/435/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/435/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/435/console
This message is automatically generated.
> RPC.waitForProxy should retry through NoRouteToHostException
> ------------------------------------------------------------
>
> Key: HADOOP-6667
> URL: https://issues.apache.org/jira/browse/HADOOP-6667
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6667.txt
>
>
> RPC.waitForProxy already loops through ConnectExceptions, but NoRouteToHostException is not a subclass of ConnectException. In the case that the NN is on a VIP, the No Route To Host error is reasonably common during a failover, so we should retry through it just the same as the other connection errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.