You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Kyle Weaver (Jira)" <ji...@apache.org> on 2021/03/16 20:48:00 UTC

[jira] [Commented] (CALCITE-4538) Make CalcRelSplitter API public.

    [ https://issues.apache.org/jira/browse/CALCITE-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302883#comment-17302883 ] 

Kyle Weaver commented on CALCITE-4538:
--------------------------------------

Beam currently has two custom physical implementations of Calc. Right now a query plan always uses either one or the other. But now we need to call both Calc implementations arbitrarily in the same plan. So we need a rule that can split a LogicalCalc. We'd obviously like to use CalcRelSplitter rather than reinventing our own algorithm to do the exact same thing. In summary, rather than "drill a hole," I'm suggesting we make CalcRelSplitter a  fully public API. Otherwise, we'll probably end up just forking it into Beam.

> Make CalcRelSplitter API public.
> --------------------------------
>
>                 Key: CALCITE-4538
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4538
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Kyle Weaver
>            Priority: Major
>
> CalcRelSplitter is a public class, but its constructor is package-private. We'd like to implement this class in Beam, which would require making the constructor public.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)