You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/04/22 04:40:16 UTC
[GitHub] [orc] dirtysalt opened a new pull request #690: fix orc-scan tool & more tools installed
dirtysalt opened a new pull request #690:
URL: https://github.com/apache/orc/pull/690
1. `buf` pointer is not forwarded after reading a chunk
2. some tools are not published.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on a change in pull request #690: fix orc-scan tool & more tools installed
Posted by GitBox <gi...@apache.org>.
wgtmac commented on a change in pull request #690:
URL: https://github.com/apache/orc/pull/690#discussion_r618890747
##########
File path: c++/src/OrcHdfsFile.cc
##########
@@ -142,18 +142,20 @@ namespace orc {
throw ParseError("Buffer is null");
}
+ char* buf_ptr = (char*)buf;
Review comment:
please use reinterpret_cast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dirtysalt commented on a change in pull request #690: fix orc-scan tool & more tools installed
Posted by GitBox <gi...@apache.org>.
dirtysalt commented on a change in pull request #690:
URL: https://github.com/apache/orc/pull/690#discussion_r618944818
##########
File path: c++/src/OrcHdfsFile.cc
##########
@@ -142,18 +142,20 @@ namespace orc {
throw ParseError("Buffer is null");
}
+ char* buf_ptr = (char*)buf;
Review comment:
@wgtmac sorry. updated. all test cases are passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac merged pull request #690: fix orc-scan tool & more tools installed
Posted by GitBox <gi...@apache.org>.
wgtmac merged pull request #690:
URL: https://github.com/apache/orc/pull/690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #690: fix orc-scan tool & more tools installed
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #690:
URL: https://github.com/apache/orc/pull/690#issuecomment-826911784
Thank you, @dirtysalt and @wgtmac !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org