You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/17 21:47:24 UTC

[GitHub] [cordova-android] raphinesse opened a new pull request #1094: test: fix unit test failures for certain random orders

raphinesse opened a new pull request #1094:
URL: https://github.com/apache/cordova-android/pull/1094


   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Some tests were not order independent
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Fixed unit tests to be independent of execution order. See commits.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Tests pass for various random orders


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] raphinesse merged pull request #1094: test: fix unit test failures for certain random orders

Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #1094:
URL: https://github.com/apache/cordova-android/pull/1094


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] codecov-io commented on pull request #1094: test: fix unit test failures for certain random orders

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1094:
URL: https://github.com/apache/cordova-android/pull/1094#issuecomment-711803972


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=h1) Report
   > Merging [#1094](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/3b56160d38c19b825f209eaee1edbcbaedf6ed77?el=desc) will **decrease** coverage by `0.22%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1094/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1094      +/-   ##
   ==========================================
   - Coverage   69.76%   69.54%   -0.23%     
   ==========================================
     Files          20       20              
     Lines        1806     1806              
   ==========================================
   - Hits         1260     1256       -4     
   - Misses        546      550       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1094/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `57.54% <0.00%> (-1.89%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=footer). Last update [3b56160...2f95944](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] codecov-io edited a comment on pull request #1094: test: fix unit test failures for certain random orders

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1094:
URL: https://github.com/apache/cordova-android/pull/1094#issuecomment-711803972


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=h1) Report
   > Merging [#1094](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/3b56160d38c19b825f209eaee1edbcbaedf6ed77?el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1094/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1094      +/-   ##
   ==========================================
   - Coverage   69.76%   69.71%   -0.06%     
   ==========================================
     Files          20       20              
     Lines        1806     1806              
   ==========================================
   - Hits         1260     1259       -1     
   - Misses        546      547       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1094/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.96% <0.00%> (-0.48%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=footer). Last update [3b56160...2f95944](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] codecov-io edited a comment on pull request #1094: test: fix unit test failures for certain random orders

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1094:
URL: https://github.com/apache/cordova-android/pull/1094#issuecomment-711803972


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=h1) Report
   > Merging [#1094](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/b1f01d7a65ccdcb0683d9867124301845b382303?el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1094/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1094   +/-   ##
   =======================================
     Coverage   69.76%   69.76%           
   =======================================
     Files          20       20           
     Lines        1806     1806           
   =======================================
     Hits         1260     1260           
     Misses        546      546           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=footer). Last update [b1f01d7...95af537](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] codecov-io edited a comment on pull request #1094: test: fix unit test failures for certain random orders

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1094:
URL: https://github.com/apache/cordova-android/pull/1094#issuecomment-711803972


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=h1) Report
   > Merging [#1094](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/3b56160d38c19b825f209eaee1edbcbaedf6ed77?el=desc) will **decrease** coverage by `0.11%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1094/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1094      +/-   ##
   ==========================================
   - Coverage   69.76%   69.65%   -0.12%     
   ==========================================
     Files          20       20              
     Lines        1806     1806              
   ==========================================
   - Hits         1260     1258       -2     
   - Misses        546      548       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1094/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.95%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=footer). Last update [3b56160...2f95944](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] codecov-io edited a comment on pull request #1094: test: fix unit test failures for certain random orders

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1094:
URL: https://github.com/apache/cordova-android/pull/1094#issuecomment-711803972


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=h1) Report
   > Merging [#1094](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/3b56160d38c19b825f209eaee1edbcbaedf6ed77?el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1094/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1094      +/-   ##
   ==========================================
   - Coverage   69.76%   69.71%   -0.06%     
   ==========================================
     Files          20       20              
     Lines        1806     1806              
   ==========================================
   - Hits         1260     1259       -1     
   - Misses        546      547       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1094/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.96% <0.00%> (-0.48%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=footer). Last update [3b56160...2f95944](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] codecov-io edited a comment on pull request #1094: test: fix unit test failures for certain random orders

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1094:
URL: https://github.com/apache/cordova-android/pull/1094#issuecomment-711803972


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=h1) Report
   > Merging [#1094](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/3b56160d38c19b825f209eaee1edbcbaedf6ed77?el=desc) will **decrease** coverage by `0.11%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1094/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1094      +/-   ##
   ==========================================
   - Coverage   69.76%   69.65%   -0.12%     
   ==========================================
     Files          20       20              
     Lines        1806     1806              
   ==========================================
   - Hits         1260     1258       -2     
   - Misses        546      548       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1094/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.95%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=footer). Last update [3b56160...2f95944](https://codecov.io/gh/apache/cordova-android/pull/1094?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org