You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2024/11/01 07:28:38 UTC
[PR] [CELEBORN-1531][FOLLOWUP] Assign the scheduleCheckTask [celeborn]
turboFei opened a new pull request, #2871:
URL: https://github.com/apache/celeborn/pull/2871
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
As title.
### Why are the changes needed?
Followup for https://github.com/apache/celeborn/pull/2653
And remove unused variable.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1531][FOLLOWUP] Assign the scheduled check task [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #2871: [CELEBORN-1531][FOLLOWUP] Assign the scheduled check task
URL: https://github.com/apache/celeborn/pull/2871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1531][FOLLOWUP] Assign the scheduleCheckTask [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2871:
URL: https://github.com/apache/celeborn/pull/2871#discussion_r1825541045
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -171,8 +171,7 @@ private[celeborn] class Master(
private var checkForWorkerTimeOutTask: ScheduledFuture[_] = _
private var checkForApplicationTimeOutTask: ScheduledFuture[_] = _
private var checkForUnavailableWorkerTimeOutTask: ScheduledFuture[_] = _
- private var checkForHDFSRemnantDirsTimeOutTask: ScheduledFuture[_] = _
- private var checkForS3RemnantDirsTimeOutTask: ScheduledFuture[_] = _
+ private var checkForDFSRemnantDirsTimeOutTask: ScheduledFuture[_] = _
Review Comment:
HDFS + S3 => DFS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1531][FOLLOWUP] Assign the scheduled check task [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2871:
URL: https://github.com/apache/celeborn/pull/2871#issuecomment-2456146739
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1531][FOLLOWUP] Assign the scheduleCheckTask [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2871:
URL: https://github.com/apache/celeborn/pull/2871#discussion_r1825509251
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -172,7 +172,6 @@ private[celeborn] class Master(
private var checkForApplicationTimeOutTask: ScheduledFuture[_] = _
private var checkForUnavailableWorkerTimeOutTask: ScheduledFuture[_] = _
private var checkForHDFSRemnantDirsTimeOutTask: ScheduledFuture[_] = _
- private var checkForS3RemnantDirsTimeOutTask: ScheduledFuture[_] = _
Review Comment:
This seems not needed anymore, as the tasks was combined for `hasHDFSStorage` and `hasS3Storage`
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -172,7 +172,6 @@ private[celeborn] class Master(
private var checkForApplicationTimeOutTask: ScheduledFuture[_] = _
private var checkForUnavailableWorkerTimeOutTask: ScheduledFuture[_] = _
private var checkForHDFSRemnantDirsTimeOutTask: ScheduledFuture[_] = _
- private var checkForS3RemnantDirsTimeOutTask: ScheduledFuture[_] = _
Review Comment:
This seems not needed anymore, as the tasks were combined for `hasHDFSStorage` and `hasS3Storage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1531][FOLLOWUP] Assign the scheduleCheckTask [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2871:
URL: https://github.com/apache/celeborn/pull/2871#discussion_r1825509251
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -172,7 +172,6 @@ private[celeborn] class Master(
private var checkForApplicationTimeOutTask: ScheduledFuture[_] = _
private var checkForUnavailableWorkerTimeOutTask: ScheduledFuture[_] = _
private var checkForHDFSRemnantDirsTimeOutTask: ScheduledFuture[_] = _
- private var checkForS3RemnantDirsTimeOutTask: ScheduledFuture[_] = _
Review Comment:
This is not needed anymore, as the task was combined for `hasHDFSStorage` and `hasS3Storage`
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -172,7 +172,6 @@ private[celeborn] class Master(
private var checkForApplicationTimeOutTask: ScheduledFuture[_] = _
private var checkForUnavailableWorkerTimeOutTask: ScheduledFuture[_] = _
private var checkForHDFSRemnantDirsTimeOutTask: ScheduledFuture[_] = _
- private var checkForS3RemnantDirsTimeOutTask: ScheduledFuture[_] = _
Review Comment:
This seems not needed anymore, as the task was combined for `hasHDFSStorage` and `hasS3Storage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org