You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2012/05/07 10:21:57 UTC
[jira] [Created] (DERBY-5746) Minor refactoring of
DataDictionaryImpl.getSetAutoincrementValue
Kristian Waagan created DERBY-5746:
--------------------------------------
Summary: Minor refactoring of DataDictionaryImpl.getSetAutoincrementValue
Key: DERBY-5746
URL: https://issues.apache.org/jira/browse/DERBY-5746
Project: Derby
Issue Type: Improvement
Components: SQL
Affects Versions: 10.9.0.0
Reporter: Kristian Waagan
Assignee: Kristian Waagan
Priority: Minor
DataDictionaryImpl.getSetAutoincrementValue contains an unused local variable, and while looking at removing it I saw that some of the statements in the method could be reordered to reduce object creation and improve readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5746) Minor refactoring of
DataDictionaryImpl.getSetAutoincrementValue
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277071#comment-13277071 ]
Dag H. Wanvik commented on DERBY-5746:
--------------------------------------
Seem good to have this debug-time check to me. +1
> Minor refactoring of DataDictionaryImpl.getSetAutoincrementValue
> ----------------------------------------------------------------
>
> Key: DERBY-5746
> URL: https://issues.apache.org/jira/browse/DERBY-5746
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.9.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-5746-1a-minor_refactoring.diff, derby-5746-2a-assert_on_fetch.diff
>
>
> DataDictionaryImpl.getSetAutoincrementValue contains an unused local variable, and while looking at removing it I saw that some of the statements in the method could be reordered to reduce object creation and improve readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5746) Minor refactoring of
DataDictionaryImpl.getSetAutoincrementValue
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-5746:
-----------------------------------
Attachment: derby-5746-2a-assert_on_fetch.diff
Attaching patch 2a, which adds asserts in the two cases where the return value from ConglomerateController.fetch are ignored.
Regression tests passed, read for review.
> Minor refactoring of DataDictionaryImpl.getSetAutoincrementValue
> ----------------------------------------------------------------
>
> Key: DERBY-5746
> URL: https://issues.apache.org/jira/browse/DERBY-5746
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.9.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-5746-1a-minor_refactoring.diff, derby-5746-2a-assert_on_fetch.diff
>
>
> DataDictionaryImpl.getSetAutoincrementValue contains an unused local variable, and while looking at removing it I saw that some of the statements in the method could be reordered to reduce object creation and improve readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5746) Minor refactoring of
DataDictionaryImpl.getSetAutoincrementValue
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-5746:
-----------------------------------
Attachment: derby-5746-1a-minor_refactoring.diff
Attaching patch 1a, which moves some of the statements around, removes one unused local variable, and adds some comments.
The regression tests passed with patch 1a.
Patch ready for review.
> Minor refactoring of DataDictionaryImpl.getSetAutoincrementValue
> ----------------------------------------------------------------
>
> Key: DERBY-5746
> URL: https://issues.apache.org/jira/browse/DERBY-5746
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.9.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-5746-1a-minor_refactoring.diff
>
>
> DataDictionaryImpl.getSetAutoincrementValue contains an unused local variable, and while looking at removing it I saw that some of the statements in the method could be reordered to reduce object creation and improve readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5746) Minor refactoring of
DataDictionaryImpl.getSetAutoincrementValue
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan closed DERBY-5746.
----------------------------------
Resolution: Fixed
Fix Version/s: 10.9.0.0
Issue & fix info: (was: Patch Available)
Thanks, Dag.
Committed patch 2a to trunk with revision 1339986.
Closing issue.
> Minor refactoring of DataDictionaryImpl.getSetAutoincrementValue
> ----------------------------------------------------------------
>
> Key: DERBY-5746
> URL: https://issues.apache.org/jira/browse/DERBY-5746
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.9.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.9.0.0
>
> Attachments: derby-5746-1a-minor_refactoring.diff, derby-5746-2a-assert_on_fetch.diff
>
>
> DataDictionaryImpl.getSetAutoincrementValue contains an unused local variable, and while looking at removing it I saw that some of the statements in the method could be reordered to reduce object creation and improve readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira