You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/08/04 10:54:11 UTC

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1314: nimble/ll/css: Fix window offset for 1st connection event

andrzej-kaczmarek opened a new pull request, #1314:
URL: https://github.com/apache/mynewt-nimble/pull/1314

   Depending on timing, connection anchor point calculated for current
   period and requested slot might have already passed at the time
   advertising PDU is received and this causes window offset to be
   calculated incorrectly. In such case we just move connection to next
   period and recalculate anchor point again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1314: nimble/ll/css: Fix window offset for 1st connection event

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged PR #1314:
URL: https://github.com/apache/mynewt-nimble/pull/1314


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1314: nimble/ll/css: Fix window offset for 1st connection event

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1314:
URL: https://github.com/apache/mynewt-nimble/pull/1314#issuecomment-1205407096

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/controller/src/ble_ll_sched.c
   <details>
   
   ```diff
   @@ -524,7 +524,7 @@
                connsm->css_period_idx++;
                ble_ll_sched_css_set_conn_anchor(connsm);
                sch->start_time =
   -                    connsm->anchor_point - g_ble_ll_sched_offset_ticks;
   +                connsm->anchor_point - g_ble_ll_sched_offset_ticks;
            } while (LL_TMR_LT(sch->start_time, orig_start_time));
    
            sch->end_time = connsm->anchor_point;
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org