You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hervé Boutemy (JIRA)" <ji...@apache.org> on 2017/06/10 21:42:20 UTC
[jira] [Closed] (MASSEMBLY-858) don't read assembly descriptor from
thread classloader but plugin classloader
[ https://issues.apache.org/jira/browse/MASSEMBLY-858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hervé Boutemy closed MASSEMBLY-858.
-----------------------------------
Resolution: Fixed
> don't read assembly descriptor from thread classloader but plugin classloader
> -----------------------------------------------------------------------------
>
> Key: MASSEMBLY-858
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-858
> Project: Maven Assembly Plugin
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Hervé Boutemy
> Assignee: Hervé Boutemy
> Priority: Minor
> Fix For: 3.0.1
>
>
> before MASSEMBLY-331 (in 2.2-beta-3), assembly descriptor was read from plugin classloader: it switched inadvertently (apparently) to thread classloader.
> In MNG-6209 for Maven 3.5.1, thread classloader evolves when plugin is flagged as extension and the assembly descriptor won't be available any more
> using thread classloader was not really a good idea, even if it didn't hurt for years: but now, it hurts: a lot of MASSEMBLY ITs related to classpath resources fail with Maven 3.5.1-SNAPSHOT:
> {noformat}
> [INFO] --- maven-invoker-plugin:3.0.0:verify (integration-test) @ maven-assembly-plugin ---
> [INFO] -------------------------------------------------
> [INFO] Build Summary:
> [INFO] Passed: 119, Failed: 14, Errors: 0, Skipped: 2
> [INFO] -------------------------------------------------
> [ERROR] The following builds failed:
> [ERROR] * projects\bugs\massembly-306\pom.xml
> [ERROR] * projects\descriptor-refs\bin\jars-in-archive-root\pom.xml
> [ERROR] * projects\descriptor-refs\jar-with-dependencies\component-descriptors-merged\pom.xml
> [ERROR] * projects\descriptor-refs\jar-with-dependencies\deps-unpacked-to-root-dir\pom.xml
> [ERROR] * projects\descriptor-refs\jar-with-dependencies\no-target-dir\pom.xml
> [ERROR] * projects\descriptor-refs\project\multimodule-sources-copied\pom.xml
> [ERROR] * projects\descriptor-refs\project\no-target-dir-multimodule\pom.xml
> [ERROR] * projects\descriptor-refs\project\no-target-dir\pom.xml
> [ERROR] * projects\descriptor-refs\project\sources-copied\pom.xml
> [ERROR] * projects\descriptor-refs\src\no-target-dir\pom.xml
> [ERROR] * projects\descriptor-refs\src\src-dir-copied\pom.xml
> [ERROR] * projects\mojo-configuration\manifest-with-customEntry\pom.xml
> [ERROR] * projects\mojo-configuration\manifest-with-mainClass\pom.xml
> [ERROR] * projects\mojo-configuration\no-appendAssemblyId-no-classifier\pom.xml
> [INFO] -------------------------------------------------
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:05 min
> [INFO] Finished at: 2017-06-05T13:14:21+02:00
> [INFO] Final Memory: 88M/1005M
> [INFO] ------------------------------------------------------------------------{noformat}
> it's time to go back to normal classloader use
> (and it's time also to not flag the plugin as extension in ITs, since it's not the usual configuration for users)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)