You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/02 14:48:50 UTC
[GitHub] [camel] orpiske opened a new pull request, #7714: CAMEL-18127: added adapter auto-configuration for AWS2 Kinesis
orpiske opened a new pull request, #7714:
URL: https://github.com/apache/camel/pull/7714
Demo (to be added to the examples repository)
[](https://asciinema.org/a/499053)
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7714: CAMEL-18127: added adapter auto-configuration for AWS2 Kinesis
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #7714:
URL: https://github.com/apache/camel/pull/7714#issuecomment-1145045560
How are the adapters discovered? Some kind of classpath discovery? If so we have the existing FactoryFinder that we use for everything in Camel ala components, languages, health checks, and other things.
The manifest files are stored in META-INF/services/org/apache/camel/...
I noticed that in this PR that it may not be the location for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7714: CAMEL-18127: added adapter auto-configuration for AWS2 Kinesis
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7714:
URL: https://github.com/apache/camel/pull/7714#issuecomment-1145022332
:x: Finished component verification: **1 component(s) test failed** out of 1 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #7714: CAMEL-18127: added adapter auto-configuration for AWS2 Kinesis
Posted by GitBox <gi...@apache.org>.
orpiske merged PR #7714:
URL: https://github.com/apache/camel/pull/7714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7714: CAMEL-18127: added adapter auto-configuration for AWS2 Kinesis
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7714:
URL: https://github.com/apache/camel/pull/7714#issuecomment-1144955501
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #7714: CAMEL-18127: added adapter auto-configuration for AWS2 Kinesis
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #7714:
URL: https://github.com/apache/camel/pull/7714#issuecomment-1145057417
> How are the adapters discovered? Some kind of classpath discovery? If so we have the existing FactoryFinder that we use for everything in Camel ala components, languages, health checks, and other things.
>
> The manifest files are stored in META-INF/services/org/apache/camel/...
>
> I noticed that in this PR that it may not be the location for this?
It reads the properties defined in the `adapter.properties` to find the adapter to load. The bulk of work was done on #7688 and now I am updating the supported components to this behavior.
In terms of code, the resolution is done in the DefaultRoute when gathering the root services [1] and then the helper searches [2] both on the classpath as well as the registry to resolve the strategy and the cache.
Thanks for mentioning the `FactoryFinder`. This is still a WIP and there's more to be done, including CAMEL-18152 and CAMEL-18128, which can benefit from this.
Relevant links:
1. https://github.com/apache/camel/blob/main/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultRoute.java#L646-L650
2. https://github.com/apache/camel/blob/main/core/camel-support/src/main/java/org/apache/camel/support/resume/AdapterHelper.java#L42-L70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7714: CAMEL-18127: added adapter auto-configuration for AWS2 Kinesis
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7714:
URL: https://github.com/apache/camel/pull/7714#issuecomment-1145099402
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7714: CAMEL-18127: added adapter auto-configuration for AWS2 Kinesis
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7714:
URL: https://github.com/apache/camel/pull/7714#issuecomment-1145031842
:x: Finished component verification: **1 component(s) test failed** out of 1 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org