[GitHub] [cassandra] maedhroz commented on a diff in pull request #1718: CASSANDRA-17706 Make sure existing delayed tasks in StreamTransferTask cannot prevent clean shutdown

[GitBox <gi...@apache.org>]

maedhroz commented on code in PR #1718:
URL: https://github.com/apache/cassandra/pull/1718#discussion_r914020013


##########
src/java/org/apache/cassandra/streaming/StreamTransferTask.java:
##########
@@ -62,6 +61,7 @@ public class StreamTransferTask extends StreamTask
     public StreamTransferTask(StreamSession session, TableId tableId)
     {
         super(session, tableId);
+        timeoutExecutor.setExecuteExistingDelayedTasksAfterShutdownPolicy(false);

Review Comment:
   @dcapwell My thinking here is that given no non-test codepath actually shuts `timeoutExecutor` down, this should be a safe change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org