You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2019/08/19 21:58:41 UTC
Review Request 71319: ATLAS-3380: Regression: After moving a table to
a different database ,
db attribute in the table entity still points to the old db.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71319/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-3380
https://issues.apache.org/jira/browse/ATLAS-3380
Repository: atlas
Description
-------
Hive commands:
1.create database db1;
2.create table table1(id int);
3.alter table table1 rename to db1.table2;
In table2's entity definition , db attribute is still pointing to default db , expected is db1. Other attributes like qualifiedName , sd's qualifiedName are pointing to db1 correctly.
Diffs
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java f496b788d
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5b24ef14e
Diff: https://reviews.apache.org/r/71319/diff/1/
Testing
-------
Manually validated the fix works.
Thanks,
Sarath Subramanian
Re: Review Request 71319: ATLAS-3380: Regression: After moving a
table to a different database ,
db attribute in the table entity still points to the old db.
Posted by Sridhar K <Sr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71319/#review217303
-----------------------------------------------------------
Ship it!
Ship It!
- Sridhar K
On Aug. 19, 2019, 9:58 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71319/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2019, 9:58 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3380
> https://issues.apache.org/jira/browse/ATLAS-3380
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Hive commands:
>
> 1.create database db1;
>
> 2.create table table1(id int);
>
> 3.alter table table1 rename to db1.table2;
>
>
>
> In table2's entity definition , db attribute is still pointing to default db , expected is db1. Other attributes like qualifiedName , sd's qualifiedName are pointing to db1 correctly.
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java f496b788d
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5b24ef14e
>
>
> Diff: https://reviews.apache.org/r/71319/diff/1/
>
>
> Testing
> -------
>
> Manually validated the fix works.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71319: ATLAS-3380: Regression: After moving a
table to a different database ,
db attribute in the table entity still points to the old db.
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71319/
-----------------------------------------------------------
(Updated Aug. 19, 2019, 4:14 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-3380
https://issues.apache.org/jira/browse/ATLAS-3380
Repository: atlas
Description
-------
Hive commands:
1.create database db1;
2.create table table1(id int);
3.alter table table1 rename to db1.table2;
In table2's entity definition , db attribute is still pointing to default db , expected is db1. Other attributes like qualifiedName , sd's qualifiedName are pointing to db1 correctly.
Diffs
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java f496b788d
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5b24ef14e
Diff: https://reviews.apache.org/r/71319/diff/1/
Testing (updated)
-------
Manually validated the fix works.
Precommit succeeded:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Atlas Server Build Tools 1.0 ................ SUCCESS [ 0.545 s]
[INFO] apache-atlas 3.0.0-SNAPSHOT ........................ SUCCESS [ 11.285 s]
[INFO] Apache Atlas Test Utility Tools 3.0.0-SNAPSHOT ..... SUCCESS [ 10.025 s]
[INFO] Apache Atlas Integration 3.0.0-SNAPSHOT ............ SUCCESS [01:23 min]
[INFO] Apache Atlas Common 3.0.0-SNAPSHOT ................. SUCCESS [ 8.129 s]
[INFO] Apache Atlas Client 3.0.0-SNAPSHOT ................. SUCCESS [ 0.334 s]
[INFO] atlas-client-common 3.0.0-SNAPSHOT ................. SUCCESS [ 4.137 s]
[INFO] atlas-client-v1 3.0.0-SNAPSHOT ..................... SUCCESS [ 5.918 s]
[INFO] Apache Atlas Server API 3.0.0-SNAPSHOT ............. SUCCESS [ 6.121 s]
[INFO] Apache Atlas Notification 3.0.0-SNAPSHOT ........... SUCCESS [ 24.046 s]
[INFO] atlas-client-v2 3.0.0-SNAPSHOT ..................... SUCCESS [ 4.452 s]
[INFO] Apache Atlas Graph Database Projects 3.0.0-SNAPSHOT SUCCESS [ 0.326 s]
[INFO] Apache Atlas Graph Database API 3.0.0-SNAPSHOT ..... SUCCESS [ 3.892 s]
[INFO] Graph Database Common Code 3.0.0-SNAPSHOT .......... SUCCESS [ 3.205 s]
[INFO] Apache Atlas JanusGraph-HBase2 Module 3.0.0-SNAPSHOT SUCCESS [ 5.510 s]
[INFO] Apache Atlas JanusGraph DB Impl 3.0.0-SNAPSHOT ..... SUCCESS [02:19 min]
[INFO] Apache Atlas Graph Database Implementation Dependencies 3.0.0-SNAPSHOT SUCCESS [ 1.361 s]
[INFO] Apache Atlas Authorization 3.0.0-SNAPSHOT .......... SUCCESS [ 7.355 s]
[INFO] Apache Atlas Repository 3.0.0-SNAPSHOT ............. SUCCESS [07:29 min]
[INFO] Apache Atlas UI 3.0.0-SNAPSHOT ..................... SUCCESS [01:02 min]
[INFO] Apache Atlas Web Application 3.0.0-SNAPSHOT ........ SUCCESS [09:04 min]
[INFO] Apache Atlas Documentation 3.0.0-SNAPSHOT .......... SUCCESS [ 5.925 s]
[INFO] Apache Atlas FileSystem Model 3.0.0-SNAPSHOT ....... SUCCESS [ 2.422 s]
[INFO] Apache Atlas Plugin Classloader 3.0.0-SNAPSHOT ..... SUCCESS [ 7.767 s]
[INFO] Apache Atlas Hive Bridge Shim 3.0.0-SNAPSHOT ....... SUCCESS [ 6.181 s]
[INFO] Apache Atlas Hive Bridge 3.0.0-SNAPSHOT ............ SUCCESS [22:07 min]
[INFO] Apache Atlas Falcon Bridge Shim 3.0.0-SNAPSHOT ..... SUCCESS [ 4.384 s]
[INFO] Apache Atlas Falcon Bridge 3.0.0-SNAPSHOT .......... SUCCESS [02:40 min]
[INFO] Apache Atlas Sqoop Bridge Shim 3.0.0-SNAPSHOT ...... SUCCESS [ 2.436 s]
[INFO] Apache Atlas Sqoop Bridge 3.0.0-SNAPSHOT ........... SUCCESS [02:42 min]
[INFO] Apache Atlas Storm Bridge Shim 3.0.0-SNAPSHOT ...... SUCCESS [ 2.687 s]
[INFO] Apache Atlas Storm Bridge 3.0.0-SNAPSHOT ........... SUCCESS [02:37 min]
[INFO] Apache Atlas Hbase Bridge Shim 3.0.0-SNAPSHOT ...... SUCCESS [ 4.331 s]
[INFO] Apache Atlas Hbase Bridge 3.0.0-SNAPSHOT ........... SUCCESS [03:01 min]
[INFO] Apache HBase - Testing Util 3.0.0-SNAPSHOT ......... SUCCESS [ 16.120 s]
[INFO] Apache Atlas Kafka Bridge 3.0.0-SNAPSHOT ........... SUCCESS [ 5.580 s]
[INFO] Apache Atlas classification updater 3.0.0-SNAPSHOT . SUCCESS [ 3.876 s]
[INFO] Apache Atlas Impala Hook API 3.0.0-SNAPSHOT ........ SUCCESS [ 2.484 s]
[INFO] Apache Atlas Impala Bridge Shim 3.0.0-SNAPSHOT ..... SUCCESS [ 2.540 s]
[INFO] Apache Atlas Impala Bridge 3.0.0-SNAPSHOT .......... SUCCESS [05:39 min]
[INFO] Apache Atlas Distribution 3.0.0-SNAPSHOT ........... SUCCESS [ 1.781 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:02 h
[INFO] Finished at: 2019-08-19T16:14:22-07:00
[INFO] ------------------------------------------------------------------------
Thanks,
Sarath Subramanian
Re: Review Request 71319: ATLAS-3380: Regression: After moving a
table to a different database ,
db attribute in the table entity still points to the old db.
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71319/#review217302
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On Aug. 19, 2019, 9:58 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71319/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2019, 9:58 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3380
> https://issues.apache.org/jira/browse/ATLAS-3380
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Hive commands:
>
> 1.create database db1;
>
> 2.create table table1(id int);
>
> 3.alter table table1 rename to db1.table2;
>
>
>
> In table2's entity definition , db attribute is still pointing to default db , expected is db1. Other attributes like qualifiedName , sd's qualifiedName are pointing to db1 correctly.
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java f496b788d
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5b24ef14e
>
>
> Diff: https://reviews.apache.org/r/71319/diff/1/
>
>
> Testing
> -------
>
> Manually validated the fix works.
>
>
> Thanks,
>
> Sarath Subramanian
>
>