You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "AshinGau (via GitHub)" <gi...@apache.org> on 2024/01/04 08:53:53 UTC

[PR] [fix](jin) add datetimev2 precision [doris]

AshinGau opened a new pull request, #29528:
URL: https://github.com/apache/doris/pull/29528

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jni) add datetimev2 precision [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29528:
URL: https://github.com/apache/doris/pull/29528#issuecomment-1878339760

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
   ```
   Tpch sf100 test result on commit 35368ab92d8c4f0e60e3e1c81179bc97e2b7a46b, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	5399	5206	5111	5111
   q2	386	165	158	158
   q3	1480	1159	1114	1114
   q4	1080	789	790	789
   q5	3157	3132	3192	3132
   q6	220	134	134	134
   q7	977	542	503	503
   q8	2180	2309	2223	2223
   q9	6710	6673	6687	6673
   q10	3198	3104	3175	3104
   q11	356	218	234	218
   q12	385	235	242	235
   q13	4409	3630	3615	3615
   q14	249	223	212	212
   q15	578	534	539	534
   q16	448	416	424	416
   q17	1054	566	526	526
   q18	7208	6725	7757	6725
   q19	1652	1580	1405	1405
   q20	549	316	342	316
   q21	2917	2505	2488	2488
   q22	399	309	339	309
   Total cold run time: 44991 ms
   Total hot run time: 39940 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	5104	5085	5096	5085
   q2	336	230	238	230
   q3	3363	3350	3329	3329
   q4	2140	2067	2017	2017
   q5	5945	5951	5961	5951
   q6	225	124	127	124
   q7	2384	1919	1909	1909
   q8	3598	3658	3680	3658
   q9	9066	9040	8964	8964
   q10	3878	3912	3937	3912
   q11	582	487	463	463
   q12	817	623	630	623
   q13	3890	3202	3204	3202
   q14	298	270	266	266
   q15	584	537	521	521
   q16	546	493	469	469
   q17	2037	1832	1810	1810
   q18	8741	8334	8294	8294
   q19	1759	1725	1722	1722
   q20	2279	1976	1968	1968
   q21	5680	5319	5310	5310
   q22	588	489	479	479
   Total cold run time: 63840 ms
   Total hot run time: 60306 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jni) add datetimev2 precision [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29528:
URL: https://github.com/apache/doris/pull/29528#issuecomment-1878333512

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 47.76 seconds
    stream load tsv:          580 seconds loaded 74807831229 Bytes, about 123 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.1 seconds inserted 10000000 Rows, about 355K ops/s
    storage size: 17184047870 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jni) add datetimev2 precision [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29528:
URL: https://github.com/apache/doris/pull/29528#issuecomment-1878444058

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jni) add datetimev2 precision [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29528:
URL: https://github.com/apache/doris/pull/29528


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jni) add datetimev2 precision [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29528:
URL: https://github.com/apache/doris/pull/29528#issuecomment-1878444018

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jin) add datetimev2 precision [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29528:
URL: https://github.com/apache/doris/pull/29528#issuecomment-1876735316

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jni) add datetimev2 precision [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29528:
URL: https://github.com/apache/doris/pull/29528#issuecomment-1878331650

   
   TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools
   ```
   TPC-DS sf100 test result on commit 35368ab92d8c4f0e60e3e1c81179bc97e2b7a46b, data reload: false
   
   run tpcds-sf100 query with default conf and session variables
   query1	928	352	340	340
   query2	6381	2079	1943	1943
   query3	6644	208	206	206
   query4	26445	22523	22512	22512
   query5	3776	502	493	493
   query6	269	183	183	183
   query7	4570	285	264	264
   query8	256	197	200	197
   query9	8159	2577	2581	2577
   query10	487	240	236	236
   query11	16253	15683	15511	15511
   query12	140	78	75	75
   query13	1637	326	314	314
   query14	11441	7172	7144	7144
   query15	214	188	205	188
   query16	6311	271	267	267
   query17	1863	499	488	488
   query18	1934	267	259	259
   query19	187	135	133	133
   query20	82	76	80	76
   query21	193	102	100	100
   query22	4990	4670	4576	4576
   query23	32396	31264	31241	31241
   query24	12144	2792	2849	2792
   query25	573	350	336	336
   query26	1594	145	138	138
   query27	2920	273	284	273
   query28	7037	1892	1883	1883
   query29	1742	382	383	382
   query30	279	142	150	142
   query31	976	766	778	766
   query32	79	65	54	54
   query33	730	266	267	266
   query34	886	456	457	456
   query35	894	799	796	796
   query36	1325	1217	1239	1217
   query37	154	69	68	68
   query38	3444	3243	3239	3239
   query39	1339	1300	1284	1284
   query40	295	88	92	88
   query41	38	35	35	35
   query42	95	83	93	83
   query43	545	488	493	488
   query44	1062	704	710	704
   query45	206	185	188	185
   query46	1081	657	632	632
   query47	1729	1614	1566	1566
   query48	331	256	257	256
   query49	1151	315	322	315
   query50	731	331	329	329
   query51	5391	5339	5316	5316
   query52	98	84	90	84
   query53	211	143	158	143
   query54	1220	563	562	562
   query55	90	89	80	80
   query56	202	188	187	187
   query57	1023	901	957	901
   query58	213	206	207	206
   query59	2818	2679	2601	2601
   query60	226	206	205	205
   query61	89	93	85	85
   query62	658	470	471	470
   query63	174	145	150	145
   query64	5479	1755	1675	1675
   query65	3372	3257	3261	3257
   query66	1268	341	339	339
   query67	15809	15447	15209	15209
   query68	11066	531	528	528
   query69	508	255	247	247
   query70	1620	1582	1477	1477
   query71	495	219	228	219
   query72	5732	3540	3511	3511
   query73	2253	314	312	312
   query74	6938	6439	6354	6354
   query75	5159	2305	2305	2305
   query76	6372	1109	1103	1103
   query77	674	255	288	255
   query78	9211	8896	8820	8820
   query79	1062	514	501	501
   query80	576	341	338	338
   query81	459	212	210	210
   query82	197	96	92	92
   query83	171	140	142	140
   query84	247	54	59	54
   query85	905	281	269	269
   query86	384	413	400	400
   query87	3519	3369	3344	3344
   query88	3020	2261	2257	2257
   query89	361	254	268	254
   query90	1984	200	199	199
   query91	124	92	91	91
   query92	58	55	60	55
   query93	2560	487	481	481
   query94	788	181	177	177
   query95	466	412	411	411
   query96	636	324	315	315
   query97	4303	4175	4175	4175
   query98	228	205	194	194
   query99	1137	855	844	844
   Total cold run time: 290490 ms
   Total hot run time: 179493 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jni) add datetimev2 precision [doris]

Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on PR #29528:
URL: https://github.com/apache/doris/pull/29528#issuecomment-1878297237

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jni) add datetimev2 precision [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29528:
URL: https://github.com/apache/doris/pull/29528#issuecomment-1878318708

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
   ```
   Tpch sf100 test result on commit 35368ab92d8c4f0e60e3e1c81179bc97e2b7a46b, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17842	5322	5064	5064
   q2	2016	159	152	152
   q3	10622	1068	1069	1068
   q4	10509	810	775	775
   q5	7816	2952	2870	2870
   q6	213	134	136	134
   q7	919	505	551	505
   q8	9295	2030	2025	2025
   q9	6847	6434	6407	6407
   q10	8264	3095	3049	3049
   q11	422	218	207	207
   q12	386	227	236	227
   q13	17996	3684	3641	3641
   q14	250	215	218	215
   q15	557	524	520	520
   q16	473	420	423	420
   q17	971	476	500	476
   q18	7631	6838	6675	6675
   q19	1584	1383	1398	1383
   q20	711	348	324	324
   q21	2808	2388	2423	2388
   q22	381	337	343	337
   Total cold run time: 108513 ms
   Total hot run time: 38862 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5158	5097	5109	5097
   q2	343	240	249	240
   q3	3302	3317	3289	3289
   q4	2133	2038	2045	2038
   q5	5847	5824	5795	5795
   q6	216	127	127	127
   q7	2348	1936	1909	1909
   q8	3349	3449	3484	3449
   q9	8837	8750	8795	8750
   q10	3795	3841	3850	3841
   q11	581	478	494	478
   q12	795	617	632	617
   q13	5809	3215	3231	3215
   q14	290	273	261	261
   q15	570	521	526	521
   q16	548	510	515	510
   q17	1968	1778	1740	1740
   q18	8708	8416	8325	8325
   q19	1628	1577	1573	1573
   q20	2186	1961	1939	1939
   q21	5600	5409	5297	5297
   q22	548	492	505	492
   Total cold run time: 64559 ms
   Total hot run time: 59503 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jni) add datetimev2 precision [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29528:
URL: https://github.com/apache/doris/pull/29528#issuecomment-1878348968

   TeamCity be ut coverage result:
    Function Coverage: 36.64% (8619/23522) 
    Line Coverage: 28.68% (70053/244295)
    Region Coverage: 27.65% (36261/131122)
    Branch Coverage: 24.35% (18522/76078)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/35368ab92d8c4f0e60e3e1c81179bc97e2b7a46b_35368ab92d8c4f0e60e3e1c81179bc97e2b7a46b/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jin) add datetimev2 precision [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29528:
URL: https://github.com/apache/doris/pull/29528#issuecomment-1876741410

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jin) add datetimev2 precision [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29528:
URL: https://github.com/apache/doris/pull/29528#issuecomment-1876888501

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org