You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2013/12/16 22:40:50 UTC
git commit: JCLOUDS-399: Deprecate BlobBuilder.calculateMD5
Updated Branches:
refs/heads/master 05ec994f9 -> ac06e32e7
JCLOUDS-399: Deprecate BlobBuilder.calculateMD5
Callers should instead call BlobBuilder.contentMD5, usually with the
results from Guava Hashing.md5(). This narrows the API and removes a
strange IOException from callers.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ac06e32e
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ac06e32e
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ac06e32e
Branch: refs/heads/master
Commit: ac06e32e72fb7a7f29489b98b736f15f2f992aa9
Parents: 05ec994
Author: Andrew Gaul <ga...@apache.org>
Authored: Mon Dec 9 13:46:49 2013 -0800
Committer: Andrew Gaul <ga...@apache.org>
Committed: Mon Dec 16 13:40:38 2013 -0800
----------------------------------------------------------------------
.../src/main/java/org/jclouds/blobstore/domain/BlobBuilder.java | 4 +++-
.../org/jclouds/blobstore/domain/internal/BlobBuilderImpl.java | 5 +++++
2 files changed, 8 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ac06e32e/blobstore/src/main/java/org/jclouds/blobstore/domain/BlobBuilder.java
----------------------------------------------------------------------
diff --git a/blobstore/src/main/java/org/jclouds/blobstore/domain/BlobBuilder.java b/blobstore/src/main/java/org/jclouds/blobstore/domain/BlobBuilder.java
index ad27986..f0b052c 100644
--- a/blobstore/src/main/java/org/jclouds/blobstore/domain/BlobBuilder.java
+++ b/blobstore/src/main/java/org/jclouds/blobstore/domain/BlobBuilder.java
@@ -130,9 +130,11 @@ public interface BlobBuilder {
PayloadBlobBuilder expires(Date expires);
/**
- *
+ * @deprecated Callers should instead call BlobBuilder.contentMD5,
+ * usually with the results from Guava Hashing.md5().
* @see Payloads#calculateMD5
*/
+ @Deprecated
PayloadBlobBuilder calculateMD5() throws IOException;
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ac06e32e/blobstore/src/main/java/org/jclouds/blobstore/domain/internal/BlobBuilderImpl.java
----------------------------------------------------------------------
diff --git a/blobstore/src/main/java/org/jclouds/blobstore/domain/internal/BlobBuilderImpl.java b/blobstore/src/main/java/org/jclouds/blobstore/domain/internal/BlobBuilderImpl.java
index 62a81e1..2d51cdb 100644
--- a/blobstore/src/main/java/org/jclouds/blobstore/domain/internal/BlobBuilderImpl.java
+++ b/blobstore/src/main/java/org/jclouds/blobstore/domain/internal/BlobBuilderImpl.java
@@ -152,6 +152,11 @@ public class BlobBuilderImpl implements BlobBuilder {
return builder.payload(payload);
}
+ /**
+ * @deprecated Callers should instead call BlobBuilder.contentMD5,
+ * usually with the results from Guava Hashing.md5().
+ */
+ @Deprecated
@Override
public PayloadBlobBuilder calculateMD5() throws IOException {
return builder.payload(Payloads.calculateMD5(payload));