You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2015/10/17 19:00:08 UTC

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-895: Use "as BinaryOp...

GitHub user okram opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/111

    TINKERPOP3-895: Use "as BinaryOperator" and remove GBinaryOperator

    https://issues.apache.org/jira/browse/TINKERPOP3-895
    
    The full test suite has passed. Integration tests not required as this does not effect the semantics of a traversal beyond `GraphTraversalSource` construction in Gremlin-Groovy.
    
    Respective lambda wrappers deprecated.
    
    No AsciiDoc documentation updates required. Will update CHANGELOG on merge to master/.
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-895

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #111
    
----
commit aee7937bac99da518865c504e6870d0b2216b066
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2015-10-17T16:57:15Z

    There is no need to have Closure wrappers to make Groovy closures line up with Java lambdas. The trick is to simply 'as Function' the closure and it is assumed to be a java.util.function.Function. I deprecated all of our GXXX closure to lambda wrappers and full test suite passes without an ambiguous method calls from Gremlin-Groovy.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-895: Use "as BinaryOp...

Posted by okram <gi...@git.apache.org>.
Github user okram closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/111


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-895: Use "as BinaryOp...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/111#issuecomment-149252205
  
    VOTE: +1 
    
    Perhaps you were going to add this after the merge, but don't forget the JIRA issue to add for future removal of the deprecated classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-895: Use "as BinaryOp...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/111#issuecomment-149316207
  
    This was merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-895: Use "as BinaryOp...

Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/111#issuecomment-148961643
  
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---