You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Matt <mi...@gmail.com> on 2016/02/17 06:46:40 UTC
Review Request 43644: Ambari should show no. of HAWQ segments live on
main dashboard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43644/
-----------------------------------------------------------
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
Bugs: AMBARI-15060
https://issues.apache.org/jira/browse/AMBARI-15060
Repository: ambari
Description
-------
The no. of HAWQ segments alive should be displayed as a widget on Ambari's main dashboard.
Diffs
-----
ambari-web/app/assets/test/tests.js 25c3f43
ambari-web/app/mappers/components_state_mapper.js 0f2b627
ambari-web/app/messages.js a7e4ff3
ambari-web/app/models.js b607bee
ambari-web/app/models/service/hawq.js PRE-CREATION
ambari-web/app/views.js 7e461f9
ambari-web/app/views/main/dashboard/widgets.js b99d881
ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js PRE-CREATION
ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/43644/diff/
Testing
-------
Manually Tested. Images attached to JIRA.
Added additional unit test.
10421 tests complete (9 seconds)
121 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:31 min
[INFO] Finished at: 2016-02-16T21:39:03-08:00
[INFO] Final Memory: 14M/432M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43644: Ambari should show no. of HAWQ segments
live on main dashboard
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43644/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 6:37 p.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
Bugs: AMBARI-15060
https://issues.apache.org/jira/browse/AMBARI-15060
Repository: ambari
Description
-------
The no. of HAWQ segments alive should be displayed as a widget on Ambari's main dashboard.
Diffs
-----
ambari-web/app/assets/test/tests.js 25c3f43
ambari-web/app/mappers/components_state_mapper.js 0f2b627
ambari-web/app/messages.js a7e4ff3
ambari-web/app/views.js 7e461f9
ambari-web/app/views/main/dashboard/widgets.js b99d881
ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js PRE-CREATION
ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/43644/diff/
Testing (updated)
-------
Manually Tested.
Images attached to JIRA.
Added additional unit test.
10416 tests complete (10 seconds)
121 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 37.827 s
[INFO] Finished at: 2016-02-18T17:51:42-08:00
[INFO] Final Memory: 12M/310M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43644: Ambari should show no. of HAWQ segments
live on main dashboard
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43644/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 5:52 p.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
Bugs: AMBARI-15060
https://issues.apache.org/jira/browse/AMBARI-15060
Repository: ambari
Description
-------
The no. of HAWQ segments alive should be displayed as a widget on Ambari's main dashboard.
Diffs (updated)
-----
ambari-web/app/assets/test/tests.js 25c3f43
ambari-web/app/mappers/components_state_mapper.js 0f2b627
ambari-web/app/messages.js a7e4ff3
ambari-web/app/views.js 7e461f9
ambari-web/app/views/main/dashboard/widgets.js b99d881
ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js PRE-CREATION
ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/43644/diff/
Testing (updated)
-------
Manually Test: results pending.
Images attached to JIRA.
Added additional unit test.
10416 tests complete (10 seconds)
121 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 37.827 s
[INFO] Finished at: 2016-02-18T17:51:42-08:00
[INFO] Final Memory: 12M/310M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43644: Ambari should show no. of HAWQ segments
live on main dashboard
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43644/#review119761
-----------------------------------------------------------
ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js (line 51)
<https://reviews.apache.org/r/43644/#comment181116>
It is being used for stopped. You'll see it when you hover over the widget.
Installed refers to that the component is in actual stopped state. It is better than doing the difference between total and started. A possible state is 'starting'.
- Matt
On Feb. 17, 2016, 11:57 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43644/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 11:57 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15060
> https://issues.apache.org/jira/browse/AMBARI-15060
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The no. of HAWQ segments alive should be displayed as a widget on Ambari's main dashboard.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js 25c3f43
> ambari-web/app/mappers/components_state_mapper.js 0f2b627
> ambari-web/app/messages.js a7e4ff3
> ambari-web/app/models.js b607bee
> ambari-web/app/models/service/hawq.js PRE-CREATION
> ambari-web/app/views.js 7e461f9
> ambari-web/app/views/main/dashboard/widgets.js b99d881
> ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js PRE-CREATION
> ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43644/diff/
>
>
> Testing
> -------
>
> Manually Tested. Images attached to JIRA.
>
> Added additional unit test.
> 10416 tests complete (10 seconds)
> 121 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 53.572 s
> [INFO] Finished at: 2016-02-17T11:55:29-08:00
> [INFO] Final Memory: 12M/311M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43644: Ambari should show no. of HAWQ segments
live on main dashboard
Posted by Matt <mi...@gmail.com>.
> On Feb. 18, 2016, 5:16 p.m., jun aoki wrote:
> > ambari-web/app/models/service/hawq.js, line 1
> > <https://reviews.apache.org/r/43644/diff/2/?file=1252996#file1252996line1>
> >
> > Is this required?
It wasn't required. Thanks for reviewing Jun!
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43644/#review119750
-----------------------------------------------------------
On Feb. 18, 2016, 6:37 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43644/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 6:37 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15060
> https://issues.apache.org/jira/browse/AMBARI-15060
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The no. of HAWQ segments alive should be displayed as a widget on Ambari's main dashboard.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js 25c3f43
> ambari-web/app/mappers/components_state_mapper.js 0f2b627
> ambari-web/app/messages.js a7e4ff3
> ambari-web/app/views.js 7e461f9
> ambari-web/app/views/main/dashboard/widgets.js b99d881
> ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js PRE-CREATION
> ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43644/diff/
>
>
> Testing
> -------
>
> Manually Tested.
> Images attached to JIRA.
>
> Added additional unit test.
> 10416 tests complete (10 seconds)
> 121 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 37.827 s
> [INFO] Finished at: 2016-02-18T17:51:42-08:00
> [INFO] Final Memory: 12M/310M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43644: Ambari should show no. of HAWQ segments
live on main dashboard
Posted by Matt <mi...@gmail.com>.
> On Feb. 18, 2016, 5:16 p.m., jun aoki wrote:
> > ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js, line 51
> > <https://reviews.apache.org/r/43644/diff/2/?file=1252999#file1252999line51>
> >
> > This may not be used as it is about started vs total?
It is being used for stopped. You'll see it when you hover over the widget.
Installed refers to that the component is in actual stopped state. It is better than computing the difference between total and started. A possible state is 'starting' which is neither 'started' not 'installed' (which corresponds to stopped).
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43644/#review119750
-----------------------------------------------------------
On Feb. 18, 2016, 5:52 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43644/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 5:52 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15060
> https://issues.apache.org/jira/browse/AMBARI-15060
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The no. of HAWQ segments alive should be displayed as a widget on Ambari's main dashboard.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js 25c3f43
> ambari-web/app/mappers/components_state_mapper.js 0f2b627
> ambari-web/app/messages.js a7e4ff3
> ambari-web/app/views.js 7e461f9
> ambari-web/app/views/main/dashboard/widgets.js b99d881
> ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js PRE-CREATION
> ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43644/diff/
>
>
> Testing
> -------
>
> Manually Test: results pending.
> Images attached to JIRA.
>
> Added additional unit test.
> 10416 tests complete (10 seconds)
> 121 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 37.827 s
> [INFO] Finished at: 2016-02-18T17:51:42-08:00
> [INFO] Final Memory: 12M/310M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43644: Ambari should show no. of HAWQ segments
live on main dashboard
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43644/#review119750
-----------------------------------------------------------
ambari-web/app/models/service/hawq.js (line 1)
<https://reviews.apache.org/r/43644/#comment181091>
Is this required?
ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js (line 51)
<https://reviews.apache.org/r/43644/#comment181105>
This may not be used as it is about started vs total?
- jun aoki
On Feb. 17, 2016, 7:57 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43644/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 7:57 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15060
> https://issues.apache.org/jira/browse/AMBARI-15060
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The no. of HAWQ segments alive should be displayed as a widget on Ambari's main dashboard.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js 25c3f43
> ambari-web/app/mappers/components_state_mapper.js 0f2b627
> ambari-web/app/messages.js a7e4ff3
> ambari-web/app/models.js b607bee
> ambari-web/app/models/service/hawq.js PRE-CREATION
> ambari-web/app/views.js 7e461f9
> ambari-web/app/views/main/dashboard/widgets.js b99d881
> ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js PRE-CREATION
> ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43644/diff/
>
>
> Testing
> -------
>
> Manually Tested. Images attached to JIRA.
>
> Added additional unit test.
> 10416 tests complete (10 seconds)
> 121 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 53.572 s
> [INFO] Finished at: 2016-02-17T11:55:29-08:00
> [INFO] Final Memory: 12M/311M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43644: Ambari should show no. of HAWQ segments
live on main dashboard
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43644/
-----------------------------------------------------------
(Updated Feb. 17, 2016, 11:57 a.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
Bugs: AMBARI-15060
https://issues.apache.org/jira/browse/AMBARI-15060
Repository: ambari
Description
-------
The no. of HAWQ segments alive should be displayed as a widget on Ambari's main dashboard.
Diffs (updated)
-----
ambari-web/app/assets/test/tests.js 25c3f43
ambari-web/app/mappers/components_state_mapper.js 0f2b627
ambari-web/app/messages.js a7e4ff3
ambari-web/app/models.js b607bee
ambari-web/app/models/service/hawq.js PRE-CREATION
ambari-web/app/views.js 7e461f9
ambari-web/app/views/main/dashboard/widgets.js b99d881
ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js PRE-CREATION
ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/43644/diff/
Testing (updated)
-------
Manually Tested. Images attached to JIRA.
Added additional unit test.
10416 tests complete (10 seconds)
121 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 53.572 s
[INFO] Finished at: 2016-02-17T11:55:29-08:00
[INFO] Final Memory: 12M/311M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43644: Ambari should show no. of HAWQ segments
live on main dashboard
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43644/#review119417
-----------------------------------------------------------
Ship it!
Ship It!
- Goutam Tadi
On Feb. 17, 2016, 5:46 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43644/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 5:46 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15060
> https://issues.apache.org/jira/browse/AMBARI-15060
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The no. of HAWQ segments alive should be displayed as a widget on Ambari's main dashboard.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js 25c3f43
> ambari-web/app/mappers/components_state_mapper.js 0f2b627
> ambari-web/app/messages.js a7e4ff3
> ambari-web/app/models.js b607bee
> ambari-web/app/models/service/hawq.js PRE-CREATION
> ambari-web/app/views.js 7e461f9
> ambari-web/app/views/main/dashboard/widgets.js b99d881
> ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js PRE-CREATION
> ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43644/diff/
>
>
> Testing
> -------
>
> Manually Tested. Images attached to JIRA.
>
> Added additional unit test.
> 10421 tests complete (9 seconds)
> 121 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:31 min
> [INFO] Finished at: 2016-02-16T21:39:03-08:00
> [INFO] Final Memory: 14M/432M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>