[GitHub] [beam] kennknowles commented on a change in pull request #13444: [BEAM-11363] Create `:sdks:java:extensions:ml:integrationTest` target, run in Java PostCommit

[GitBox <gi...@apache.org>]

kennknowles commented on a change in pull request #13444:
URL: https://github.com/apache/beam/pull/13444#discussion_r535466952



##########
File path: sdks/java/extensions/ml/build.gradle
##########
@@ -44,11 +44,30 @@ dependencies {
     testRuntimeOnly project(":runners:google-cloud-dataflow-java")
 }
 
-project.test {
-    def gcpProject = project.findProperty("gcpProject") ?: 'apache-beam-testing'
-    include "**/**IT.class"
-    def pipelineOptions = [
-            "--project=${gcpProject}"
-    ]
-    systemProperty "beamTestPipelineOptions", JsonOutput.toJson(pipelineOptions)
+/**
+ * These are integration tests with the GCP ML services and the DirectRunner.
+ */
+task integrationTest(type: Test) {
+  group = "Verification"
+  def gcpProject = project.findProperty('gcpProject') ?: 'apache-beam-testing'
+  def gcpTempRoot = project.findProperty('gcpTempRoot') ?: 'gs://temp-storage-for-end-to-end-tests'
+  systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+          "--runner=DirectRunner",
+          "--project=${gcpProject}",
+          "--tempRoot=${gcpTempRoot}",
+  ])
+
+  // Disable Gradle cache: these ITs interact with live service that should always be considered "out of date"
+  outputs.upToDateWhen { false }

Review comment:
       Just want to note that "UP-TO-DATE" and "FROM-CACHE" are two different Gradle statuses for a task. I presume if it is never up to date it is also never cached...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org