You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2011/06/06 21:26:48 UTC

DO NOT REPLY [Bug 51329] New: Code clean up (mod_imagemap.c)

https://issues.apache.org/bugzilla/show_bug.cgi?id=51329

             Bug #: 51329
           Summary: Code clean up (mod_imagemap.c)
           Product: Apache httpd-2
           Version: 2.3-HEAD
          Platform: PC
        OS/Version: Windows 2000
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: mod_imap
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: christophe.jaillet@wanadoo.fr
    Classification: Unclassified


Created attachment 27120
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27120
Proposed patch

Hi,

here is a patch that makes some small speed-up/clean-up in 'mod_imagemap.c'.


1) use apr_palloc instead of apr_pcalloc when all the fields of the allocated
structure are set afterwards.

2) avoid useless calls to 'strcasecmp' when we have already found what we are
looking for.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 51329] Code clean up (mod_imagemap.c)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51329

Christophe JAILLET <ch...@wanadoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 51329] Code clean up (mod_imagemap.c)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51329

Stefan Fritsch <sf...@sfritsch.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Stefan Fritsch <sf...@sfritsch.de> 2011-06-13 11:24:43 UTC ---
I have commited this patch as r1135089.

But I think that mod_imagemap, mod_ident, and mod_cern_meta are so utterly
obsolete that we should not waste more time on optimizing them. Please
concentrate on different code parts in the future ;-) . Thanks.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org