You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2019/06/28 11:27:00 UTC
[jira] [Resolved] (DIRSERVER-2270) Inconsistent log level practices
[ https://issues.apache.org/jira/browse/DIRSERVER-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny resolved DIRSERVER-2270.
------------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0.AM26
Fixed with commit {{85879f25020f5ca9f7b96e176687978e99e90583}}
Thanks for the report !
> Inconsistent log level practices
> --------------------------------
>
> Key: DIRSERVER-2270
> URL: https://issues.apache.org/jira/browse/DIRSERVER-2270
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: core
> Affects Versions: 2.0.0.AM25
> Reporter: Anuhan Torgonshar
> Priority: Major
> Labels: easyfix
> Fix For: 2.0.0.AM26
>
>
> Hi,
> I found there are inconsistent log level practices in the Qpid project, and we suspect the following practice should be fixed.
> The detail code as well as the modification suggestion are shown below.
> {code:java}
> problematic logging practice:
> ====================DefaultDirectoryServiceFactory.java==================
> file path: apacheds-parent-2.0.0.AM25\core-annotations\src\main\java\org\apache\directory\server\core\factory\DefaultDirectoryServiceFactory.java
> logging statement line: 151
> modification suggestion: change log level to ERROR
> 145 try
> 146 {
> 147 FileUtils.deleteDirectory( instanceLayout.getInstanceDirecto ry() );
> 148 }
> 149 catch ( IOException e )
> 150 {
> 151 LOG.warn( "couldn't delete the instance directory before ini tializing the DirectoryService", e );
> 152 }
> similar code snippet:
> ====================IntegrationUtils.java================================
> file path: apacheds-parent-2.0.0.AM25\core-integ\src\main\java\org\apache\directory\server\core\integ\IntegrationUtils.java
> logging statement line: 91
> 85 try
> 86 {
> 87 FileUtils.deleteDirectory( wkdir );
> 88 }
> 89 catch ( IOException e )
> 90 {
> 91 LOG.error( I18n.err( I18n.ERR_115 ), e );
> 92 }
> {code}
> We will highly appreciate your feedback!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org