You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/18 11:10:38 UTC

[GitHub] [cloudstack-documentation] davidjumani opened a new pull request #156: Adding docs for noVNC

davidjumani opened a new pull request #156:
URL: https://github.com/apache/cloudstack-documentation/pull/156


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] davidjumani commented on a change in pull request #156: Adding docs for noVNC

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #156:
URL: https://github.com/apache/cloudstack-documentation/pull/156#discussion_r490878609



##########
File path: source/adminguide/systemvm.rst
##########
@@ -112,13 +112,21 @@ to the VNC port made available via the hypervisor for the console of the
 guest. Both the administrator and end user web UIs offer a console
 connection.
 
-Clicking a console icon brings up a new window. The AJAX code downloaded
+Clicking a console icon brings up a new window. The console viewer
 into that window refers to the public IP address of a console proxy VM.
 There is exactly one public IP address allocated per console proxy VM.
-The AJAX application connects to this IP. The console proxy then proxies
+The viewer application connects to this IP. The console proxy then proxies
 the connection to the VNC port for the requested VM on the Host hosting
 the guest.
 
+Since 4.14, noVNC has been integrated into the console proxy and is the

Review comment:
       Fixed!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #156: Adding docs for noVNC

Posted by GitBox <gi...@apache.org>.
ACSGitBot commented on pull request #156:
URL: https://github.com/apache/cloudstack-documentation/pull/156#issuecomment-694826755


   Your request had been received, i'll go and build the documentation and check the output log for errors.
   
   This shouldn't take long.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] weizhouapache commented on a change in pull request #156: Adding docs for noVNC

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #156:
URL: https://github.com/apache/cloudstack-documentation/pull/156#discussion_r490877316



##########
File path: source/adminguide/systemvm.rst
##########
@@ -112,13 +112,21 @@ to the VNC port made available via the hypervisor for the console of the
 guest. Both the administrator and end user web UIs offer a console
 connection.
 
-Clicking a console icon brings up a new window. The AJAX code downloaded
+Clicking a console icon brings up a new window. The console viewer
 into that window refers to the public IP address of a console proxy VM.
 There is exactly one public IP address allocated per console proxy VM.
-The AJAX application connects to this IP. The console proxy then proxies
+The viewer application connects to this IP. The console proxy then proxies
 the connection to the VNC port for the requested VM on the Host hosting
 the guest.
 
+Since 4.14, noVNC has been integrated into the console proxy and is the

Review comment:
       4.15 ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] rhtyd merged pull request #156: Adding docs for noVNC

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #156:
URL: https://github.com/apache/cloudstack-documentation/pull/156


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] davidjumani commented on pull request #156: Adding docs for noVNC

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #156:
URL: https://github.com/apache/cloudstack-documentation/pull/156#issuecomment-694826714


   requesting docbuild


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #156: Adding docs for noVNC

Posted by GitBox <gi...@apache.org>.
ACSGitBot commented on pull request #156:
URL: https://github.com/apache/cloudstack-documentation/pull/156#issuecomment-694827731


   Build finished.  You can review it at:   https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr156
   
   Build Log Output:
   
   
   No log errors found to report.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org