You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/07 09:21:05 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #5080: ui: Show default nic/network in infocard

davidjumani opened a new pull request #5080:
URL: https://github.com/apache/cloudstack/pull/5080


   ### Description
   
   Shows default next to the default network / nic
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   
   ### Screenshots (if appropriate):
   
   #### Deploy VM :
   
   ![Screenshot from 2021-06-07 14-48-46](https://user-images.githubusercontent.com/8244774/120991846-a6607980-c79f-11eb-821c-8ac85554d232.png)
   
   
   #### VM Instance :
   
   ![Screenshot from 2021-06-07 14-48-24](https://user-images.githubusercontent.com/8244774/120991902-b24c3b80-c79f-11eb-9d37-f1c881fbdd18.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #5080: ui: Show default nic/network in infocard

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5080:
URL: https://github.com/apache/cloudstack/pull/5080#discussion_r647103814



##########
File path: ui/src/components/view/InfoCard.vue
##########
@@ -281,6 +281,9 @@
                 style="margin-left: -24px; margin-top: 5px;">
                 <a-icon type="api" />eth{{ index }} {{ eth.ipaddress }}
                 <router-link v-if="eth.networkname && eth.networkid" :to="{ path: '/guestnetwork/' + eth.networkid }">({{ eth.networkname }})</router-link>
+                <span v-if="eth.isdefault">

Review comment:
       Added tags for nics but not for networks so it maintains the theme
   
   ![Screenshot from 2021-06-08 10-06-42](https://user-images.githubusercontent.com/8244774/121123706-4ae6c800-c841-11eb-8b39-4a4af7f85083.png)
   ![Screenshot from 2021-06-08 10-06-53](https://user-images.githubusercontent.com/8244774/121123715-4c17f500-c841-11eb-96ca-d7b13468cde0.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5080: ui: Show default nic/network in infocard

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5080:
URL: https://github.com/apache/cloudstack/pull/5080#issuecomment-856434954


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5080 (SL-JID-222)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5080: ui: Show default nic/network in infocard

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5080:
URL: https://github.com/apache/cloudstack/pull/5080#issuecomment-859422580


   @GabrielBrascher you are the second lgtm and imply that you tested, any reason you didn't merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5080: ui: Show default nic/network in infocard

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5080:
URL: https://github.com/apache/cloudstack/pull/5080#discussion_r646534041



##########
File path: ui/src/components/view/InfoCard.vue
##########
@@ -281,6 +281,9 @@
                 style="margin-left: -24px; margin-top: 5px;">
                 <a-icon type="api" />eth{{ index }} {{ eth.ipaddress }}
                 <router-link v-if="eth.networkname && eth.networkid" :to="{ path: '/guestnetwork/' + eth.networkid }">({{ eth.networkname }})</router-link>
+                <span v-if="eth.isdefault">

Review comment:
       Instead of parenthesis can you use a tiny tag https://www.antdv.com/components/tag/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5080: ui: Show default nic/network in infocard

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5080:
URL: https://github.com/apache/cloudstack/pull/5080#discussion_r646442989



##########
File path: ui/src/components/view/InfoCard.vue
##########
@@ -281,6 +281,9 @@
                 style="margin-left: -24px; margin-top: 5px;">
                 <a-icon type="api" />eth{{ index }} {{ eth.ipaddress }}
                 <router-link v-if="eth.networkname && eth.networkid" :to="{ path: '/guestnetwork/' + eth.networkid }">({{ eth.networkname }})</router-link>
+                <span v-if="eth.isdefault">

Review comment:
       @davidjumani the default I think is usually the first; more clearly seen from the nics tab.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5080: ui: Show default nic/network in infocard

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5080:
URL: https://github.com/apache/cloudstack/pull/5080#issuecomment-856432893


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #5080: ui: Show default nic/network in infocard

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5080:
URL: https://github.com/apache/cloudstack/pull/5080#issuecomment-856432730


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org