You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/12/15 16:42:09 UTC

[GitHub] [incubator-yunikorn-scheduler-interface] manirajv06 commented on pull request #58: YUNIKORN-462: Streamline core to shim update on allocation change

manirajv06 commented on pull request #58:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/58#issuecomment-994967159


   In addition to changes discussed offline, have also made changes for synchronous release allocations in a separate flow as I thought of not disturbing the other use cases (trigger points) which are ok with async communication. This kind of synchronous release allocations is required only for processAllocationReleases() method because call to ForgotPod() happens only in this flow through ReSyncSchedulerCache plugin.
   
   Once overall approach makes sense, will need to work on unit tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org