You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by gosubpl <gi...@git.apache.org> on 2017/05/17 00:06:06 UTC
[GitHub] flink pull request #3926: [FLINK-6570] QueryableStateClient docs with matchi...
GitHub user gosubpl opened a pull request:
https://github.com/apache/flink/pull/3926
[FLINK-6570] QueryableStateClient docs with matching constructor sign…
Resolves [FLINK-6570] by modifying the example for `QuerableStateClient` usage by adding the `highAvailabilityServices` argument.
Tested with `querablestatedemo` project.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gosubpl/flink FLINK-6570
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3926.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3926
----
commit 789d62dac1ff49e1870573d2e9092ab63f58dbcd
Author: gosubpl <gi...@gosub.pl>
Date: 2017-05-17T00:03:45Z
[FLINK-6570] QueryableStateClient docs with matching constructor signature
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3926: [FLINK-6570] QueryableStateClient docs with matchi...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3926#discussion_r117180703
--- Diff: docs/dev/stream/queryable_state.md ---
@@ -208,10 +208,16 @@ Once used in a job, you can retrieve the job ID and then query any key's current
{% highlight java %}
final Configuration config = new Configuration();
-config.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY, queryAddress);
-config.setInteger(ConfigConstants.JOB_MANAGER_IPC_PORT_KEY, queryPort);
+config.setString(JobManagerOptions.ADDRESS, queryAddress);
+config.setInteger(JobManagerOptions.PORT, queryPort);
-QueryableStateClient client = new QueryableStateClient(config);
+final HighAvailabilityServices highAvailabilityServices =
+ HighAvailabilityServicesUtils.createHighAvailabilityServices(
+ config,
+ TestingUtils.defaultExecutor(),
+ HighAvailabilityServicesUtils.AddressResolution.NO_ADDRESS_RESOLUTION);
--- End diff --
Better to do `TRY_ADDRESS_RESOLUTION` here so that we fail fast in case the JM is not reachable from the node we are currently running on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3926: [FLINK-6570] QueryableStateClient docs with matching cons...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3926
Sadly, our tests are a little bit unstable. The issue is not related to your change.
@tillrohrmann could you talk a quick look here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3926: [FLINK-6570] QueryableStateClient docs with matching cons...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3926
Thanks for your contribution @gosubpl. Changes look good to me. Merging this and addressing my comment while doing so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3926: [FLINK-6570] QueryableStateClient docs with matching cons...
Posted by gosubpl <gi...@git.apache.org>.
Github user gosubpl commented on the issue:
https://github.com/apache/flink/pull/3926
Please note that the only change in this PR is a documentation change. Not sure why this should result in test failing. How can another test run be requested (a _flaky test_ perhaps)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3926: [FLINK-6570] QueryableStateClient docs with matchi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3926
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---