[jira] [Commented] (CALCITE-840) Protobuf transport for Avatica

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708485#comment-14708485 ] 

Julian Hyde commented on CALCITE-840:
-------------------------------------

Looks good at this point. I was surprised how large the patch is - but not your fault at all, I guess it's quite a big protocol. Nor is its protobuf's fault - everything seems to translate quite naturally.

In a few places you have default constructors that assign null to final members of type Map or List and I presume that protobuf uses Unsafe to re-assign them. Is it valid for users of those classes to assume that the Map and List members are not null?

And it would be good to fix CALCITE-839 before committing this. It seems wrong that any file would have both jackson and protobuf imports, and 839 would concentrate the jackson imports in a smaller number of files.

Please be sure to use 3rd person declarative for javadoc method comments.

Obviously files will need license headers and other fixup before commit.

> Protobuf transport for Avatica
> ------------------------------
>
>                 Key: CALCITE-840
>                 URL: https://issues.apache.org/jira/browse/CALCITE-840
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Julian Hyde
>            Assignee: Josh Elser
>         Attachments: CALCITE-840.001.patch
>
>
> Create a transport for Avatica that uses Protobuf.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)