You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/17 15:48:47 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #6136: api: Allow updating VM settings when custom contrained offering is used
Pearl1594 opened a new pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136
### Description
This PR fixes: https://github.com/apache/cloudstack/issues/6131
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
1. Create a VM using custom constrained compute offering
2. Stop VM
3. Update VM settings - successfully gets updated
4. Start VM - vm starts successfully
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6136: api: Allow updating VM settings when custom contrained offering is used
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071000906
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6136: api: Allow updating VM settings when custom constrained offering is used
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071179732
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6136: api: Allow updating VM settings when custom contrained offering is used
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071003115
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6136: api: Allow updating VM settings when custom constrained offering is used
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071466453
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6136: api: Allow updating VM settings when custom contrained offering is used
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071105286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6136: api: Allow updating VM settings when custom constrained offering is used
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071138611
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache merged pull request #6136: api: Allow updating VM settings when custom constrained offering is used
Posted by GitBox <gi...@apache.org>.
weizhouapache merged pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6136: api: Allow updating VM settings when custom constrained offering is used
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071464361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6136: api: Allow updating VM settings when custom contrained offering is used
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071003115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6136: api: Allow updating VM settings when custom constrained offering is used
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071139996
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6136: api: Allow updating VM settings when custom constrained offering is used
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1072056331
<b>Trillian test result (tid-3657)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30804 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6136-t3657-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_nic | `Error` | 145.67 | test_nic.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6136: api: Allow updating VM settings when custom constrained offering is used
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1072078070
code here looks good and the `test_nic` error has been popping up in a lot of PRs lately. (cc @nvazquez @weizhouapache )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache merged pull request #6136: api: Allow updating VM settings when custom constrained offering is used
Posted by GitBox <gi...@apache.org>.
weizhouapache merged pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6136: api: Allow updating VM settings when custom contrained offering is used
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071000906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6136: api: Allow updating VM settings when custom contrained offering is used
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071080397
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6136: api: Allow updating VM settings when custom constrained offering is used
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1072123956
> code here looks good and the `test_nic` error has been popping up in a lot of PRs lately. (cc @nvazquez @weizhouapache )
@DaanHoogland
the issue should have been fixed by #5645
```
test_01_nic (tests.smoke.test_nic.TestNic): DEBUG: Exception during NIC test SETUP!: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:The VLAN tag to use for new guest network, 1201 is already being used for dynamic vlan allocation for the guest network in zone pr6136-t3657-kvm-centos7
```
looks like a trillian config issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6136: api: Allow updating VM settings when custom contrained offering is used
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071105286
code looks good @Pearl1594 but can you base on 4.16, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6136: api: Allow updating VM settings when custom constrained offering is used
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6136:
URL: https://github.com/apache/cloudstack/pull/6136#issuecomment-1071464361
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org