[GitHub] [lucene] dweiss commented on a change in pull request #80: LUCENE-9925: add checksums to snowball-generated files

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #80:
URL: https://github.com/apache/lucene/pull/80#discussion_r612177428



##########
File path: gradle/generation/snowball.gradle
##########
@@ -114,5 +133,5 @@ configure(project(":lucene:analysis:common")) {
     }
   }
 
-  regenerate.dependsOn mustRunInOrder([snowball, "spotlessApply"])
+  regenerate.dependsOn wrapWithPersistentChecksums(snowball, [ andThenTasks: "spotlessApply", ignoreWithSource: [downloadSnowballStemmers, downloadSnowballWebsite, downloadSnowballData] ])

Review comment:
       > Maybe these individual tasks simply shouldnt be exposed at all, because they only cause pain, only regenerate really does everything (such as updating the checksums files).
   
   Agreed - they shouldn't be exposed. And they sort of are not - if you run the task list they won't show up (their "wrapped" equivalents are shown - snowballIfNeeded). I agree the per-project or global convention "regenerate" should be the "standard" way of regenerating things and I explicitly warned about using low-level regeneration tasks in the docs:
   
   https://github.com/apache/lucene/blob/main/help/regeneration.txt#L135-L143
   
   Don't get me wrong, I'm not too happy about how it currently works (wrapper tasks, complex wire-up logic) but I spent a day or two thinking whether this can be done easier (Occam's razor) and I didn't find a better solution... If I come up with something I'm certainly up for replacing those wrapper tasks...
   
   > But i forgot that damn 12GB DFA is in there :)
   
   LOL. https://github.com/apache/lucene/blob/main/help/regeneration.txt#L145-L148




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org