You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ne...@apache.org on 2017/05/10 04:58:29 UTC

[5/8] mesos git commit: Fixed `Version::validateIdentifier()` for Unicode edge case.

Fixed `Version::validateIdentifier()` for Unicode edge case.

The test case `u8"1.0.0-b\u00e9ta"` in `VersionTest.ParseInvalid` caused
an abort in `isctype.cpp` with VS 2017. Changing the `char` to an
`unsigned char` prevents this.

Review: https://reviews.apache.org/r/59110/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/1af90dfc
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/1af90dfc
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/1af90dfc

Branch: refs/heads/1.3.x
Commit: 1af90dfc954eaaea6bc927d60bf336315ec29e66
Parents: 347ad21
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Authored: Tue May 9 14:06:01 2017 -0700
Committer: Neil Conway <ne...@gmail.com>
Committed: Tue May 9 21:29:16 2017 -0700

----------------------------------------------------------------------
 3rdparty/stout/include/stout/version.hpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/1af90dfc/3rdparty/stout/include/stout/version.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/version.hpp b/3rdparty/stout/include/stout/version.hpp
index 9120e42..4be7222 100644
--- a/3rdparty/stout/include/stout/version.hpp
+++ b/3rdparty/stout/include/stout/version.hpp
@@ -299,7 +299,7 @@ private:
       return Error("Empty identifier");
     }
 
-    auto alphaNumericOrHyphen = [](char c) -> bool {
+    auto alphaNumericOrHyphen = [](unsigned char c) -> bool {
       return std::isalnum(c) || c == '-';
     };