You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by di...@apache.org on 2007/01/03 03:22:24 UTC
svn commit: r492014 - in
/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2:
transport/http/HTTPTransportUtils.java util/JavaUtils.java
Author: dims
Date: Tue Jan 2 18:22:24 2007
New Revision: 492014
URL: http://svn.apache.org/viewvc?view=rev&rev=492014
Log:
port 491624 - optimize java keyword search a bit. reduce calls to getProperty/getParameter
Modified:
webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/http/HTTPTransportUtils.java
webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/util/JavaUtils.java
Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/http/HTTPTransportUtils.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/http/HTTPTransportUtils.java?view=diff&rev=492014&r1=492013&r2=492014
==============================================================================
--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/http/HTTPTransportUtils.java (original)
+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/http/HTTPTransportUtils.java Tue Jan 2 18:22:24 2007
@@ -98,30 +98,28 @@
public static boolean doWriteMTOM(MessageContext msgContext) {
boolean enableMTOM = false;
-
- if (msgContext.getParameter(Constants.Configuration.ENABLE_MTOM) != null) {
+ Parameter parameter = msgContext.getParameter(Constants.Configuration.ENABLE_MTOM);
+ if (parameter != null) {
enableMTOM = JavaUtils.isTrueExplicitly(
- msgContext.getParameter(Constants.Configuration.ENABLE_MTOM).getValue());
+ parameter.getValue());
}
-
- if (msgContext.getProperty(Constants.Configuration.ENABLE_MTOM) != null) {
- enableMTOM = JavaUtils.isTrueExplicitly(
- msgContext.getProperty(Constants.Configuration.ENABLE_MTOM));
+ Object property = msgContext.getProperty(Constants.Configuration.ENABLE_MTOM);
+ if (property != null) {
+ enableMTOM = JavaUtils.isTrueExplicitly(property);
}
return enableMTOM;
}
public static boolean doWriteSwA(MessageContext msgContext) {
boolean enableSwA = false;
-
- if (msgContext.getParameter(Constants.Configuration.ENABLE_SWA) != null) {
+ Parameter parameter = msgContext.getParameter(Constants.Configuration.ENABLE_SWA);
+ if (parameter != null) {
enableSwA = JavaUtils.isTrueExplicitly(
- msgContext.getParameter(Constants.Configuration.ENABLE_SWA).getValue());
+ parameter.getValue());
}
-
- if (msgContext.getProperty(Constants.Configuration.ENABLE_SWA) != null) {
- enableSwA = JavaUtils.isTrueExplicitly(
- msgContext.getProperty(Constants.Configuration.ENABLE_SWA));
+ Object property = msgContext.getProperty(Constants.Configuration.ENABLE_SWA);
+ if (property != null) {
+ enableSwA = JavaUtils.isTrueExplicitly(property);
}
return enableSwA;
}
Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/util/JavaUtils.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/util/JavaUtils.java?view=diff&rev=492014&r1=492013&r2=492014
==============================================================================
--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/util/JavaUtils.java (original)
+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/util/JavaUtils.java Tue Jan 2 18:22:24 2007
@@ -71,7 +71,29 @@
* @return Returns boolean.
*/
public static boolean isJavaKeyword(String keyword) {
+ // None of the java keywords have uppercase characters
+ if(hasUpperCase(keyword)) {
+ return false;
+ }
return (Arrays.binarySearch(keywords, keyword, englishCollator) >= 0);
+ }
+
+ /**
+ * Check if the word has any uppercase letters
+ *
+ * @param word
+ * @return
+ */
+ public static boolean hasUpperCase(String word) {
+ if (word == null)
+ return false;
+ int len = word.length();
+ for (int i = 0; i < len; i++) {
+ if (Character.isUpperCase(word.charAt(i))) {
+ return true;
+ }
+ }
+ return false;
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org