[GitHub] [calcite] zstan commented on a diff in pull request #2889: [CALCITE-5253] Natural join fields validation partially broken after CALCITE-5171

[GitBox <gi...@apache.org>]

zstan commented on code in PR #2889:
URL: https://github.com/apache/calcite/pull/2889#discussion_r985385913


##########
core/src/main/java/org/apache/calcite/rel/type/RelCrossType.java:
##########
@@ -58,6 +58,15 @@ public RelCrossType(
     return false;
   }
 
+  /**
+   * Returns the contained types.
+   *
+   * @return Data types.
+   */
+  public ImmutableList<RelDataType> getTypes() {

Review Comment:
   good catch, thanks !



##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -6163,7 +6163,7 @@ private ImmutableList<ImmutableBitSet> cube(ImmutableBitSet... sets) {
   /** Test case for
    * <a href="https://issues.apache.org/jira/browse/CALCITE-5171">[CALCITE-5171]
    * NATURAL join and USING should fail if join columns are not unique</a>. */
-  @Test void testNaturalJoinDuplicateColumns() {
+  @Test void testJoinDuplicateColumns() {

Review Comment:
   fixed, thanks !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org