You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/09/04 11:01:02 UTC

[GitHub] [thrift] caspertwo opened a new pull request #2230: THRIFT-5103: Fix for PHP7.4 deprecated syntax

caspertwo opened a new pull request #2230:
URL: https://github.com/apache/thrift/pull/2230


   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [ ] Did you squash your changes to a single commit?  (not required, but preferred)
   - [ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] caspertwo commented on pull request #2230: THRIFT-5103: Fix for PHP7.4 deprecated syntax

Posted by GitBox <gi...@apache.org>.
caspertwo commented on pull request #2230:
URL: https://github.com/apache/thrift/pull/2230#issuecomment-690658473


   Thanks @chriskapp! PR has been updated


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] sveneld commented on pull request #2230: THRIFT-5103: Fix for PHP7.4 deprecated syntax

Posted by GitBox <gi...@apache.org>.
sveneld commented on pull request #2230:
URL: https://github.com/apache/thrift/pull/2230#issuecomment-689582034


   @ulidtko please look 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] chriskapp commented on pull request #2230: THRIFT-5103: Fix for PHP7.4 deprecated syntax

Posted by GitBox <gi...@apache.org>.
chriskapp commented on pull request #2230:
URL: https://github.com/apache/thrift/pull/2230#issuecomment-689665552


   Great, maybe you want also fix this directly at the TCurlClient s.: https://github.com/apache/thrift/blob/master/lib/php/lib/Transport/TCurlClient.php#L102


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G closed pull request #2230: THRIFT-5103: Fix for PHP7.4 deprecated syntax

Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2230:
URL: https://github.com/apache/thrift/pull/2230


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] sveneld commented on pull request #2230: THRIFT-5103: Fix for PHP7.4 deprecated syntax

Posted by GitBox <gi...@apache.org>.
sveneld commented on pull request #2230:
URL: https://github.com/apache/thrift/pull/2230#issuecomment-689578656


   @Jens-G it's important fix for migrating to php 7.4


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org