[jira] [Commented] (OAK-2195) Repository upgrade does not correctly update jcr:all aggregate privileges and bits

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173507#comment-14173507 ] 

angela commented on OAK-2195:
-----------------------------

not sure... it feels really wrong to me that the upgrade code manually tries to enforce what the corresponding commit hooks and validators do in a regular setup... for example it sets the jcr:all privilege, but does it also set the next-bits?

IMO the correct fix would be to have all built-in privileges installed by the corresponding initializer first and then regularly register those privileges from the jackrabbit 2.x instance that are not yet registered... i.e. only registering custom privileges. and again: from my point of view the registration should not be done manually on the node builder but rather with the corresponding commithooks in place that make sure the privilege content is consistent. then, the upgrader doesn't have to know about the implementation details.

> Repository upgrade does not correctly update jcr:all aggregate privileges and bits
> ----------------------------------------------------------------------------------
>
>                 Key: OAK-2195
>                 URL: https://issues.apache.org/jira/browse/OAK-2195
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: upgrade
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: production, upgrade
>         Attachments: OAK-2195.patch
>
>
> When custom privileges are present {{jcr:all}} does not correctly reflect those via {{#getAggregatePrivileges}} and via its bit map. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)