You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "jiayuasu (via GitHub)" <gi...@apache.org> on 2026/03/04 09:12:53 UTC
[PR] [GH-2678] Add SVG illustrations for predicate functions [sedona]
jiayuasu opened a new pull request, #2681:
URL: https://github.com/apache/sedona/pull/2681
## Did you read the Contributor Guide?
- Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
## Is this PR related to a ticket?
- Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #2678
## What changes were proposed in this PR?
Added SVG visual illustrations for 13 spatial predicate functions, showing both TRUE and FALSE cases for each:
- ST_Contains, ST_CoveredBy, ST_Covers, ST_Crosses, ST_Disjoint, ST_DWithin, ST_Equals, ST_Intersects, ST_OrderingEquals, ST_Overlaps, ST_Relate, ST_Touches, ST_Within
Each predicate gets two SVG diagrams (true/false case) stored in `docs/image/ST_<Name>/`. The diagrams use blue for Geometry A and red for Geometry B with clear labeling.
The samThe samThe sameferenced from all three doThe samThe samThocThe samThe samThe sameferenced from all threThe samThe samThe sameferenced from all three doThe sa/`
ST_RelateMatST_RelateMatST_RelateMatST_RelateMatST_RelateMatriST_RelateMatST_RelateMatST_RelateMatST_RelateMatST_RelateMatriST_RelateMatST_RelateMatST_RelateMatST_RelateMatST_RelateMatriST_RelateMatST_RelateMatST_RelateMatST_RelateMatST_RelatileST_RelateMatST_RelateMatST_Relat PR ST_RelateMatST_RelateMatST_RelateMatST_RelateMatST_RelateMatriST_RelateMatSTation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-2678] Add SVG illustrations for predicate functions [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #2681:
URL: https://github.com/apache/sedona/pull/2681#discussion_r2882764207
##########
docs/api/sql/Predicates/ST_Relate.md:
##########
@@ -21,6 +21,9 @@
Introduction: The first variant of the function computes and returns the [Dimensionally Extended 9-Intersection Model (DE-9IM)](https://en.wikipedia.org/wiki/DE-9IM) matrix string representing the spatial relationship between the two input geometry objects.
+
+
+
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-2678] Add SVG illustrations for predicate functions [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #2681:
URL: https://github.com/apache/sedona/pull/2681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-2678] Add SVG illustrations for predicate functions [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #2681:
URL: https://github.com/apache/sedona/pull/2681#discussion_r2885673800
##########
docs/api/snowflake/vector-data/Predicates/ST_Relate.md:
##########
@@ -23,6 +23,9 @@ Introduction: The first variant of the function computes and returns the [Dimens
The second variant of the function evaluates whether the two input geometries satisfy a specific spatial relationship defined by the provided `intersectionMatrix` pattern.
+
+
+
Review Comment:
fixed
##########
docs/api/flink/Predicates/ST_Relate.md:
##########
@@ -23,6 +23,9 @@ Introduction: The first variant of the function computes and returns the [Dimens
The second variant of the function evaluates whether the two input geometries satisfy a specific spatial relationship defined by the provided `intersectionMatrix` pattern.
+
+
+
Review Comment:
fixed
##########
docs/api/sql/Predicates/ST_Relate.md:
##########
@@ -23,6 +23,9 @@ Introduction: The first variant of the function computes and returns the [Dimens
The second variant of the function evaluates whether the two input geometries satisfy a specific spatial relationship defined by the provided `intersectionMatrix` pattern.
+
+
+
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-2678] Add SVG illustrations for predicate functions [sedona]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2681:
URL: https://github.com/apache/sedona/pull/2681#discussion_r2882781931
##########
docs/api/snowflake/vector-data/Predicates/ST_Relate.md:
##########
@@ -23,6 +23,9 @@ Introduction: The first variant of the function computes and returns the [Dimens
The second variant of the function evaluates whether the two input geometries satisfy a specific spatial relationship defined by the provided `intersectionMatrix` pattern.
+
+
+
Review Comment:
The newly added diagrams/alt text describe ST_Relate “returning true/false”, but this page still states `Return type: String` even though the second overload (`ST_Relate(…, intersectionMatrix)`) returns a boolean (the example output below is `true`). Please update the return type section to reflect both overloads (e.g., String for the 2-arg variant and Boolean for the 3-arg variant) and/or adjust the diagram captions to explicitly tie them to the boolean-pattern overload.
##########
docs/api/sql/Predicates/ST_Relate.md:
##########
@@ -23,6 +23,9 @@ Introduction: The first variant of the function computes and returns the [Dimens
The second variant of the function evaluates whether the two input geometries satisfy a specific spatial relationship defined by the provided `intersectionMatrix` pattern.
+
+
+
Review Comment:
The newly added diagrams/alt text describe ST_Relate “returning true/false”, but this page still states `Return type: String` even though the second overload (`ST_Relate(…, intersectionMatrix)`) returns a boolean (the example output below is `true`). Please update the return type section to reflect both overloads (e.g., String for the 2-arg variant and Boolean for the 3-arg variant) and/or adjust the diagram captions to explicitly tie them to the boolean-pattern overload.
##########
docs/api/flink/Predicates/ST_Relate.md:
##########
@@ -23,6 +23,9 @@ Introduction: The first variant of the function computes and returns the [Dimens
The second variant of the function evaluates whether the two input geometries satisfy a specific spatial relationship defined by the provided `intersectionMatrix` pattern.
+
+
+
Review Comment:
The newly added diagrams/alt text describe ST_Relate “returning true/false”, but this page still states `Return type: String` even though the second overload (`ST_Relate(…, intersectionMatrix)`) returns a boolean (the example output below is `true`). Please update the return type section to reflect both overloads (e.g., String for the 2-arg variant and Boolean for the 3-arg variant) and/or adjust the diagram captions to explicitly tie them to the boolean-pattern overload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-2678] Add SVG illustrations for predicate functions [sedona]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2681:
URL: https://github.com/apache/sedona/pull/2681#discussion_r2882742000
##########
docs/api/sql/Predicates/ST_Relate.md:
##########
@@ -21,6 +21,9 @@
Introduction: The first variant of the function computes and returns the [Dimensionally Extended 9-Intersection Model (DE-9IM)](https://en.wikipedia.org/wiki/DE-9IM) matrix string representing the spatial relationship between the two input geometry objects.
+
+
+
Review Comment:
The diagrams shown here depict the boolean-pattern overload (as indicated by the SVG title `ST_Relate(A, B, '…')` and TRUE/FALSE badges), but they’re inserted immediately after the paragraph describing the *first* overload that returns a DE-9IM `String`. This placement (and the “returning true/false” wording) is misleading given the surrounding text and the page’s `Return type: String` section. Consider moving the images below the paragraph introducing the second overload (or adding a short sentence clarifying they illustrate the pattern-matching overload), and adjusting alt/title text accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org