[GitHub] curator pull request #216: CURATOR-402: Curator should not use QuorumServer....

[lvfangmin <gi...@git.apache.org>]

Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/curator/pull/216#discussion_r126874138
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/EnsembleTracker.java ---
    @@ -170,8 +170,10 @@ public static String configToConnectionString(QuorumVerifier data) throws Except
                 {
                     sb.append(",");
                 }
    -            InetSocketAddress address = Objects.firstNonNull(server.clientAddr, server.addr);
    -            sb.append(address.getAddress().getHostAddress()).append(":").append(address.getPort());
    +            InetSocketAddress clientAddress = server.clientAddr;
    --- End diff --
    
    After ZooKeeper 3.5, if the zoo.cfg is in old format which has clientPort and server list being defined, then the clientAddr will be 0.0.0.0, which shouldn't be used as the server hostAddress. CURATOR-392 reported some issues similar, and it has handled this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---