You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/09 15:49:58 UTC

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #706: GEODE-8773: Test that PING and CLOSE_CONNECTION are not implicitly transactional.

pdxcodemonkey commented on a change in pull request #706:
URL: https://github.com/apache/geode-native/pull/706#discussion_r539421503



##########
File path: cppcache/integration/framework/Cluster.cpp
##########
@@ -110,6 +109,12 @@ void Locator::start() {
                      .withPreferIPv6(cluster_.getUseIPv6())
                      .withJmxManagerStart(true);
 
+  if(cluster_.getLogLevel().empty()) {

Review comment:
       Switched to a simple unit test, framework changes are gone.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org