You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "sourrabhh (via GitHub)" <gi...@apache.org> on 2026/01/11 07:07:36 UTC
[PR] Add test for StringUtils.isBlank handling tab characters [commons-lang]
sourrabhh opened a new pull request, #1562:
URL: https://github.com/apache/commons-lang/pull/1562
This PR adds a missing unit test for StringUtils.isBlank
to verify behavior with tab-only strings.
No production code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add test for StringUtils.isBlank handling tab characters [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1562:
URL: https://github.com/apache/commons-lang/pull/1562#issuecomment-3734400942
Hello @sourrabhh
This is a change for the sake of change, as tabs are already tested in `StringUtilsEmptyBlankTest.testIsBlank()` and this test doesn't cause a different code path to be executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add test for StringUtils.isBlank handling tab characters [commons-lang]
Posted by "sourrabhh (via GitHub)" <gi...@apache.org>.
sourrabhh closed pull request #1562: Add test for StringUtils.isBlank handling tab characters
URL: https://github.com/apache/commons-lang/pull/1562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add test for StringUtils.isBlank handling tab characters [commons-lang]
Posted by "sourrabhh (via GitHub)" <gi...@apache.org>.
sourrabhh commented on PR #1562:
URL: https://github.com/apache/commons-lang/pull/1562#issuecomment-3735221247
Hello @garydgregory
Thanks for the review and the clarification.
I see that tabs are already covered by StringUtilsEmptyBlankTest.testIsBlank()
and that this test does not exercise a different code path.
I’m still getting familiar with the existing test coverage, so I appreciate the guidance.
I’ll close this PR and will look for an issue or test case that adds new coverage or behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org