You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/23 08:49:48 UTC

[GitHub] [arrow-rs] jhorstmann commented on pull request #1589: Fix Null Mask Handling in ArrayData And UnionArray

jhorstmann commented on PR #1589:
URL: https://github.com/apache/arrow-rs/pull/1589#issuecomment-1107435883

   Looks good. This is some really gnarly code and last time I tried to improve it I gave up since it was never clear whether the start variable already include offsets or where the offsets have to be applied.
   
   I have two tests in #1499 where `assert_eq` was not working, the one comparing list arrays works with these changes, I'm currently looking into the other one comparing two struct arrays.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org