You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/20 15:37:09 UTC
[GitHub] [incubator-seatunnel] TyrantLucifer opened a new pull request, #2823: [Bug] [Connector-V2] Fix hive source connector parallelism not work
TyrantLucifer opened a new pull request, #2823:
URL: https://github.com/apache/incubator-seatunnel/pull/2823
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
fix #2812
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2823: [Bug] [Connector-V2] Fix hive source connector parallelism not work
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2823:
URL: https://github.com/apache/incubator-seatunnel/pull/2823#discussion_r975966769
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/split/FileSourceSplitEnumerator.java:
##########
@@ -56,45 +55,54 @@ public void open() {
@Override
public void run() {
- pendingSplit = getHiveFileSplit();
- assignSplit(context.registeredReaders());
+ // do nothing
}
- private Set<FileSourceSplit> getHiveFileSplit() {
- Set<FileSourceSplit> hiveSourceSplits = new HashSet<>();
- filePaths.forEach(k -> hiveSourceSplits.add(new FileSourceSplit(k)));
- return hiveSourceSplits;
-
+ private Set<FileSourceSplit> getFileSplit() {
+ Set<FileSourceSplit> fileSourceSplits = new HashSet<>();
+ filePaths.forEach(k -> fileSourceSplits.add(new FileSourceSplit(k)));
Review Comment:
Is `filePaths` possible to be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2823: [Bug] [Connector-V2] Fix hive source connector parallelism not work
Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #2823:
URL: https://github.com/apache/incubator-seatunnel/pull/2823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2823: [Bug] [Connector-V2] Fix hive source connector parallelism not work
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2823:
URL: https://github.com/apache/incubator-seatunnel/pull/2823#discussion_r975987917
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/split/FileSourceSplitEnumerator.java:
##########
@@ -56,45 +55,54 @@ public void open() {
@Override
public void run() {
- pendingSplit = getHiveFileSplit();
- assignSplit(context.registeredReaders());
+ // do nothing
Review Comment:
line#52 `assignedSplit` cannot be re -initialized, it may contain restore state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2823: [Bug] [Connector-V2] Fix hive source connector parallelism not work
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2823:
URL: https://github.com/apache/incubator-seatunnel/pull/2823#discussion_r975966769
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/split/FileSourceSplitEnumerator.java:
##########
@@ -56,45 +55,54 @@ public void open() {
@Override
public void run() {
- pendingSplit = getHiveFileSplit();
- assignSplit(context.registeredReaders());
+ // do nothing
}
- private Set<FileSourceSplit> getHiveFileSplit() {
- Set<FileSourceSplit> hiveSourceSplits = new HashSet<>();
- filePaths.forEach(k -> hiveSourceSplits.add(new FileSourceSplit(k)));
- return hiveSourceSplits;
-
+ private Set<FileSourceSplit> getFileSplit() {
+ Set<FileSourceSplit> fileSourceSplits = new HashSet<>();
+ filePaths.forEach(k -> fileSourceSplits.add(new FileSourceSplit(k)));
Review Comment:
Is `filePaths` possible to be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org