[I] Report the actual Fineract operation that failed in integration errors [fineract-loan-origination]

["KRYSTALM7 (via GitHub)" <gi...@apache.org>]

KRYSTALM7 opened a new issue, #163:
URL: https://github.com/apache/fineract-loan-origination/issues/163

   ## Problem
   
   Fineract integration errors currently report `POST /loans` regardless of which step actually failed.
   
   The disbursement lifecycle contains multiple external operations:
   
   1. Create loan
   2. Approve loan
   3. Disburse loan
   
   The error response should identify the actual failed operation.
   
   ## Root Cause
   
   `MSG_FINERACT_CALL_FAILED_TEMPLATE` is hard-coded to report:
   
   `POST /loans`
   
   for every Fineract integration failure.
   
   ## Impact
   
   Operators and developers cannot immediately determine which step failed.
   
   This makes production debugging and recovery more difficult.
   
   ## Proposed Fix
   
   Pass the operation name/path into the integration exception.
   
   Examples:
   
   - `POST /loans`
   - `POST /loans/{id}?command=approve`
   - `POST /loans/{id}?command=disburse`
   
   The response should preserve the existing error format while identifying the failing step.
   
   ## Acceptance Criteria
   
   - [ ] Loan creation failures identify loan creation.
   - [ ] Approval failures identify loan approval.
   - [ ] Disbursement failures identify loan disbursement.
   - [ ] Existing error handling remains compatible.
   
   ## Regression Tests
   
   - [ ] Create failure contains create operation.
   - [ ] Approval failure contains approve operation.
   - [ ] Disbursement failure contains disburse operation.
   
   ## Dependencies 
   
   Related to #154.
   
   The error reporting improvements are part of hardening the real Fineract integration and will ensure failures identify the specific Fineract operation that failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Report the actual Fineract operation that failed in integration errors [fineract-loan-origination]

["KRYSTALM7 (via GitHub)" <gi...@apache.org>]

KRYSTALM7 commented on issue #163:
URL: https://github.com/apache/fineract-loan-origination/issues/163#issuecomment-6058829807

   I’ll take ownership of this as part of the Fineract integration. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org