You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "mochengqian (via GitHub)" <gi...@apache.org> on 2026/05/24 10:38:45 UTC
[I] cluster: avoid double-clone of endpoints across assemble and snapshot publish [dubbo-go-pixiu]
mochengqian opened a new issue, #940:
URL: https://github.com/apache/dubbo-go-pixiu/issues/940
Every `ClusterStore.prepareClusterConfig` call clones the full endpoint slice through `assembleClusterEndpoints`, and every snapshot publish clones again in `newEndpointSnapshot`.
The double clone exists for two legitimate boundaries:
- `assembleClusterEndpoints` must not mutate operator-supplied `*Endpoint` values while assigning default IDs and names.
- `EndpointSnapshot` must not share `*Endpoint` values with the mutable `Config.Endpoints` side.
This can create allocation pressure for registries or LLM clusters with high endpoint churn.
Proposed:
- Add a membership-churn benchmark, for example 1000 endpoints plus repeated `SetEndpoint` calls.
- Decide which boundary owns cloning based on behavior compatibility and measured allocation savings.
- Keep any behavior-changing option documented in CHANGELOG before implementation.
Reference: PR #932 keeps the double clone intentionally to avoid shifting review focus away from snapshot correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [FEATURE] Avoid double-cloning endpoints during snapshot publication [dubbo-go-pixiu]
Posted by "ywxzm03 (via GitHub)" <gi...@apache.org>.
ywxzm03 commented on issue #940:
URL: https://github.com/apache/dubbo-go-pixiu/issues/940#issuecomment-4602398741
Could you assign this issue to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [FEATURE] Avoid double-cloning endpoints during snapshot publication [dubbo-go-pixiu]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks closed issue #940: [FEATURE] Avoid double-cloning endpoints during snapshot publication
URL: https://github.com/apache/dubbo-go-pixiu/issues/940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] cluster: avoid double-clone of endpoints across assemble and snapshot publish [dubbo-go-pixiu]
Posted by "mochengqian (via GitHub)" <gi...@apache.org>.
mochengqian commented on issue #940:
URL: https://github.com/apache/dubbo-go-pixiu/issues/940#issuecomment-4528291130
@mochengqian
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org