You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "Donvi (via GitHub)" <gi...@apache.org> on 2024/04/18 06:53:02 UTC
[PR] [GLUTEN-5448][VL] Fix the issue of cleaning when left with previous build in velox-backends part [incubator-gluten]
Donvi opened a new pull request, #5449:
URL: https://github.com/apache/incubator-gluten/pull/5449
## What changes were proposed in this pull request?
Just add sudo command to
(Fixes: \#ISSUE-5448)
## How was this patch tested?
mannual test in local build and find it can work well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5448][VL] Fix the issue of cleaning when left with previous build in velox-backends part [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5449:
URL: https://github.com/apache/incubator-gluten/pull/5449#issuecomment-2063149921
https://github.com/apache/incubator-gluten/issues/5448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5448][VL] Fix the issue of cleaning when left with previous build in velox-backends part [incubator-gluten]
Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha commented on code in PR #5449:
URL: https://github.com/apache/incubator-gluten/pull/5449#discussion_r1570335030
##########
dev/builddeps-veloxbe.sh:
##########
@@ -189,7 +189,7 @@ function build_velox {
function build_gluten_cpp {
echo "Start to Gluten CPP"
cd $GLUTEN_DIR/cpp
- rm -rf build
+ sudo rm -rf build
mkdir build
cd build
Review Comment:
do we really need this change? if you need sudo rm, you will need sudo mkdir too, could you double check it?
##########
ep/build-velox/src/build_velox.sh:
##########
@@ -209,7 +209,7 @@ function check_commit {
fi
else
# Branch-new build requires all untracked files to be deleted. We only need the source code.
- git clean -dffx :/
+ sudo git clean -dffx :/
Review Comment:
great catch!
##########
dev/builddeps-veloxbe.sh:
##########
@@ -213,4 +213,4 @@ commands_to_run=${OTHER_ARGUMENTS:-}
"${cmd}"
done
fi
-)
\ No newline at end of file
+)
Review Comment:
just avoid introducing unnecessary changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5448][VL] Fix the issue of cleaning when left with previous build in velox-backends part [incubator-gluten]
Posted by "Donvi (via GitHub)" <gi...@apache.org>.
Donvi commented on code in PR #5449:
URL: https://github.com/apache/incubator-gluten/pull/5449#discussion_r1571995391
##########
dev/builddeps-veloxbe.sh:
##########
@@ -189,7 +189,7 @@ function build_velox {
function build_gluten_cpp {
echo "Start to Gluten CPP"
cd $GLUTEN_DIR/cpp
- rm -rf build
+ sudo rm -rf build
mkdir build
cd build
Review Comment:
Thanks for reminding, fixed. But this is only for removing, so this should not influence the build result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5448][VL] Fix the issue of cleaning when left with previous build in velox-backends part [incubator-gluten]
Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha merged PR #5449:
URL: https://github.com/apache/incubator-gluten/pull/5449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5448][VL] Fix the issue of cleaning when left with previous build in velox-backends part [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5449:
URL: https://github.com/apache/incubator-gluten/pull/5449#issuecomment-2068403998
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_5449_time.csv</font></td>
<td><font color=#000000>log/native_master_04_21_2024_b08258e51_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>37.44</font></td>
<td><font color=#6F9915>34.90</font></td>
<td><font color=#6F9915>-2.544</font></td>
<td><font color=#6F9915>93.21%</font></td>
</tr>
<tr>
<td><font color=#F92663>q2</font></td>
<td><font color=#F92663>22.05</font></td>
<td><font color=#F92663>24.06</font></td>
<td><font color=#F92663>2.015</font></td>
<td><font color=#F92663>109.14%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>36.78</font></td>
<td><font color=#6F9915>36.70</font></td>
<td><font color=#6F9915>-0.083</font></td>
<td><font color=#6F9915>99.77%</font></td>
</tr>
<tr>
<td><font color=#F92663>q4</font></td>
<td><font color=#F92663>39.05</font></td>
<td><font color=#F92663>40.96</font></td>
<td><font color=#F92663>1.903</font></td>
<td><font color=#F92663>104.87%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>70.53</font></td>
<td><font color=#6F9915>69.60</font></td>
<td><font color=#6F9915>-0.928</font></td>
<td><font color=#6F9915>98.68%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>7.40</font></td>
<td><font color=#F92663>7.44</font></td>
<td><font color=#F92663>0.042</font></td>
<td><font color=#F92663>100.57%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>85.90</font></td>
<td><font color=#6F9915>85.59</font></td>
<td><font color=#6F9915>-0.310</font></td>
<td><font color=#6F9915>99.64%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q8</font></td>
<td><font color=#6F9915>86.41</font></td>
<td><font color=#6F9915>85.37</font></td>
<td><font color=#6F9915>-1.043</font></td>
<td><font color=#6F9915>98.79%</font></td>
</tr>
<tr>
<td><font color=#F92663>q9</font></td>
<td><font color=#F92663>124.39</font></td>
<td><font color=#F92663>125.78</font></td>
<td><font color=#F92663>1.391</font></td>
<td><font color=#F92663>101.12%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>43.54</font></td>
<td><font color=#6F9915>43.35</font></td>
<td><font color=#6F9915>-0.190</font></td>
<td><font color=#6F9915>99.56%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q11</font></td>
<td><font color=#6F9915>20.26</font></td>
<td><font color=#6F9915>19.84</font></td>
<td><font color=#6F9915>-0.426</font></td>
<td><font color=#6F9915>97.90%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q12</font></td>
<td><font color=#6F9915>26.85</font></td>
<td><font color=#6F9915>25.80</font></td>
<td><font color=#6F9915>-1.054</font></td>
<td><font color=#6F9915>96.08%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q13</font></td>
<td><font color=#6F9915>55.61</font></td>
<td><font color=#6F9915>54.10</font></td>
<td><font color=#6F9915>-1.513</font></td>
<td><font color=#6F9915>97.28%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>22.30</font></td>
<td><font color=#6F9915>21.91</font></td>
<td><font color=#6F9915>-0.388</font></td>
<td><font color=#6F9915>98.26%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>28.85</font></td>
<td><font color=#F92663>29.24</font></td>
<td><font color=#F92663>0.391</font></td>
<td><font color=#F92663>101.36%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q16</font></td>
<td><font color=#6F9915>14.36</font></td>
<td><font color=#6F9915>14.28</font></td>
<td><font color=#6F9915>-0.078</font></td>
<td><font color=#6F9915>99.46%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q17</font></td>
<td><font color=#6F9915>101.42</font></td>
<td><font color=#6F9915>101.35</font></td>
<td><font color=#6F9915>-0.074</font></td>
<td><font color=#6F9915>99.93%</font></td>
</tr>
<tr>
<td><font color=#F92663>q18</font></td>
<td><font color=#F92663>144.31</font></td>
<td><font color=#F92663>145.10</font></td>
<td><font color=#F92663>0.783</font></td>
<td><font color=#F92663>100.54%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q19</font></td>
<td><font color=#6F9915>14.94</font></td>
<td><font color=#6F9915>13.61</font></td>
<td><font color=#6F9915>-1.327</font></td>
<td><font color=#6F9915>91.12%</font></td>
</tr>
<tr>
<td><font color=#F92663>q20</font></td>
<td><font color=#F92663>27.72</font></td>
<td><font color=#F92663>28.46</font></td>
<td><font color=#F92663>0.738</font></td>
<td><font color=#F92663>102.66%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>284.69</font></td>
<td><font color=#F92663>287.28</font></td>
<td><font color=#F92663>2.594</font></td>
<td><font color=#F92663>100.91%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>14.54</font></td>
<td><font color=#F92663>14.78</font></td>
<td><font color=#F92663>0.240</font></td>
<td><font color=#F92663>101.65%</font></td>
</tr>
<tr>
<td><font color=#F92663>total</font></td>
<td><font color=#F92663>1309.38</font></td>
<td><font color=#F92663>1309.52</font></td>
<td><font color=#F92663>0.140</font></td>
<td><font color=#F92663>100.01%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org