You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/03/13 03:08:18 UTC
[GitHub] [cassandra-builds] dcapwell opened a new pull request #14:
CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to
support parameterized tests
dcapwell opened a new pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on issue #14:
CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to
support parameterized tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on issue #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14#issuecomment-599274188
Committed as https://github.com/apache/cassandra-builds/commit/9781ca1b4e7489afa09a33b8943d599b47cfe233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] dcapwell commented on a change in pull request
#14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to
support parameterized tests
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14#discussion_r392512128
##########
File path: jenkins-dsl/cassandra_pipeline.groovy
##########
@@ -40,7 +40,7 @@ pipeline {
stage('JVM DTests') {
steps {
warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test-jvm-dtest-forking", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
+ build job: "${env.JOB_NAME}-jvm-dtest", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
Review comment:
https://github.com/apache/cassandra/pull/472
tested that 3.11's patch cherry picks into 3.0 and 2.2 cleanly; for some reason trunk -> 3.11 doesn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] dcapwell commented on a change in pull request
#14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to
support parameterized tests
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14#discussion_r392626954
##########
File path: jenkins-dsl/cassandra_pipeline.groovy
##########
@@ -40,7 +40,7 @@ pipeline {
stage('JVM DTests') {
steps {
warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test-jvm-dtest-forking", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
+ build job: "${env.JOB_NAME}-jvm-dtest", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
Review comment:
sure, will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a change in pull
request #14: CASSANDRA-15639 Jenkins build for jvm test should use
testclasslist to support parameterized tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14#discussion_r392587322
##########
File path: jenkins-dsl/cassandra_pipeline.groovy
##########
@@ -40,7 +40,7 @@ pipeline {
stage('JVM DTests') {
steps {
warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test-jvm-dtest-forking", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
+ build job: "${env.JOB_NAME}-jvm-dtest", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
Review comment:
Could we just keep the name suffix as `-test-jvm-dtest-forking` for now, and come back to changing it later on?
Adding a `todo` comment to do the rename would be useful.
(I suspect there will be other changes that involve updating both repositories, over multiple branches, later on. and would rather just avoid it for now :( apologises for the confusion)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a change in pull
request #14: CASSANDRA-15639 Jenkins build for jvm test should use
testclasslist to support parameterized tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14#discussion_r392587322
##########
File path: jenkins-dsl/cassandra_pipeline.groovy
##########
@@ -40,7 +40,7 @@ pipeline {
stage('JVM DTests') {
steps {
warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test-jvm-dtest-forking", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
+ build job: "${env.JOB_NAME}-jvm-dtest", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
Review comment:
Could we just keep the name suffix as `-test-jvm-dtest-forking` for now, and come back to changing it later on?
(I suspect there will be other changes that involve updating both repositories, over multiple branches, later on. and would rather just avoid it for now :( apologises for the confusion)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] dcapwell commented on a change in pull request
#14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to
support parameterized tests
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14#discussion_r392496709
##########
File path: jenkins-dsl/cassandra_job_dsl_seed.groovy
##########
@@ -372,6 +377,24 @@ cassandraBranches.each {
}
}
+ /**
+ * Main branch test script target jobs
+ */
+ testScriptTargets.each {
+ def targetName = it
+
+ job("${jobNamePrefix}-${targetName}") {
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever closed pull request #14:
CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to
support parameterized tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever closed pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a change in pull
request #14: CASSANDRA-15639 Jenkins build for jvm test should use
testclasslist to support parameterized tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14#discussion_r392488908
##########
File path: jenkins-dsl/cassandra_job_dsl_seed.groovy
##########
@@ -372,6 +377,24 @@ cassandraBranches.each {
}
}
+ /**
+ * Main branch test script target jobs
+ */
+ testScriptTargets.each {
+ def targetName = it
+
+ job("${jobNamePrefix}-${targetName}") {
Review comment:
can we, for now, remove the `testScriptTargets` array and the each-loop here? ie, just make this a one-off `job(…)` like "*-artifacts", "*-cqlsh-tests", and the pipelines.
(or did you have further jobs in mind to add to this array?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a change in pull
request #14: CASSANDRA-15639 Jenkins build for jvm test should use
testclasslist to support parameterized tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14#discussion_r392505748
##########
File path: jenkins-dsl/cassandra_pipeline.groovy
##########
@@ -40,7 +40,7 @@ pipeline {
stage('JVM DTests') {
steps {
warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test-jvm-dtest-forking", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
+ build job: "${env.JOB_NAME}-jvm-dtest", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
Review comment:
changing the name is not so easy, because it also needs to be changed [here](https://github.com/apache/cassandra/blob/trunk/.jenkins/Jenkinsfile#L88)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] dcapwell commented on a change in pull request
#14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to
support parameterized tests
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14#discussion_r392510998
##########
File path: jenkins-dsl/cassandra_pipeline.groovy
##########
@@ -40,7 +40,7 @@ pipeline {
stage('JVM DTests') {
steps {
warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test-jvm-dtest-forking", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
+ build job: "${env.JOB_NAME}-jvm-dtest", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
Review comment:
https://github.com/apache/cassandra/pull/471
checked 2.2 and the cherry pick failed, so will add PR per branch which doesn't clean apply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on a change in pull
request #14: CASSANDRA-15639 Jenkins build for jvm test should use
testclasslist to support parameterized tests
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14#discussion_r392505748
##########
File path: jenkins-dsl/cassandra_pipeline.groovy
##########
@@ -40,7 +40,7 @@ pipeline {
stage('JVM DTests') {
steps {
warnError('Tests unstable') {
- build job: "${env.JOB_NAME}-test-jvm-dtest-forking", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
+ build job: "${env.JOB_NAME}-jvm-dtest", parameters: [string(name: 'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
Review comment:
changing the name is not so easy, because it also needs to be changed [here](https://github.com/apache/cassandra/blob/trunk/.jenkins/Jenkinsfile#L88) (on all branches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org