You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/09 18:28:45 UTC

[GitHub] brodybits opened a new pull request #542: Resolve GH-540 (hotfix)

brodybits opened a new pull request #542: Resolve GH-540 (hotfix)
URL: https://github.com/apache/cordova-android/pull/542
 
 
   - include commits with hotfix & unit test proposed in GH-539 (PR #539)
   - revert 8a69e32 - CB-14125:(android) Increase old plugin compatibility
   - include unit test from PR #541 to verify that GH-540 is resolved
   
   ## Explanation
   
   Issues reported in #539 & #540, as reproduced in #541, were introduced in 7.1.2 due to the following changes:
   
   * [CB-13830](https://issues.apache.org/jira/browse/CB-13830): Add handlers for plugins that use non-Java source files, such as Camera (commit ea6477f4d3e63ebb1f1717cc02e3117aa356ce84)
   * [CB-14125](https://issues.apache.org/jira/browse/CB-14125): Increase old plugin compatibility (commit 8a69e328004a20810eec4466cbda7fa9013e21ec)
   
   The major change in [CB-13830](https://issues.apache.org/jira/browse/CB-13830) was to factor some Android Studio path remapping code into a `studioPathRemap` function, but it had a small issue that is resolved in PR #539.
   
   The change in [CB-14125](https://issues.apache.org/jira/browse/CB-14125) caused the issue reported in GH-540 and should not have been present in a patch release.
   
   ## TODO
   
   One of the following options for the master branch, for the next major release:
   1. Include all changes except for revert of [CB-14125](https://issues.apache.org/jira/browse/CB-14125)
   2. Include all changes in the master branch
   
   I would favor option 2, which reverts [CB-14125](https://issues.apache.org/jira/browse/CB-14125) in the next major release as well. Old plugins should be updated to reflect the new directory structure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org