[GitHub] [helix] xyuanlu commented on a change in pull request #2006: Add type and reason for batch disable/enable

[GitBox <gi...@apache.org>]

xyuanlu commented on a change in pull request #2006:
URL: https://github.com/apache/helix/pull/2006#discussion_r840950298



##########
File path: helix-common/src/main/java/org/apache/helix/StringProcessUtil.java
##########
@@ -0,0 +1,38 @@
+package org.apache.helix;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+
+public class StringProcessUtil {
+  private static final String CONCATENATE_CONFIG_SPLITTER = ",";

Review comment:
       TFTR. Right now the two existing use cases all use "," and "=".  I think it is OK to hard code it for now. 

##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
##########
@@ -352,27 +353,28 @@ public void enableInstance(final String clusterName, final String instanceName,
         clusterName);
     BaseDataAccessor<ZNRecord> baseAccessor = new ZkBaseDataAccessor<>(_zkClient);
     enableSingleInstance(clusterName, instanceName, enabled, baseAccessor, disabledType, reason);

Review comment:
       TFTR. Updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org