You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/10 16:43:50 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #18068: Switch dumb-init to propagate signals to child process only

potiuk commented on a change in pull request #18068:
URL: https://github.com/apache/airflow/pull/18068#discussion_r706325427



##########
File path: Dockerfile
##########
@@ -479,6 +479,7 @@ LABEL org.apache.airflow.distro="debian" \
   org.opencontainers.image.title="Production Airflow Image" \
   org.opencontainers.image.description="Reference, production-ready Apache Airflow image"
 
+ENV DUMB_INIT_SETSID="1"
 

Review comment:
       This is the "explicit is better than implicit" at it fullest. :) . 
   
   By adding it here, anyone who gets the Dockerfile and modify it will be aware of the existence of that variable, and **might** start thinking what it is about, without actually reading the documentation. 
   
   There are two kinds of engineers: those who read all the docs and those who 'just try and see' - this is more for the latter crowd.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org