[GitHub] [incubator-iceberg] rdblue commented on issue #841: Upgrade Hive to 2.3.6 for Iceberg

[GitBox <gi...@apache.org>]

rdblue commented on issue #841: Upgrade Hive to 2.3.6 for Iceberg
URL: https://github.com/apache/incubator-iceberg/pull/841#issuecomment-598809775
 
 
   Thanks for working on this, @jerryshao! I think the code part is close -- I'd just prefer to use the `DynMethods` builder to avoid try/catch and custom reflect code.
   
   We also need to take a close look at all the dependency additions and remove whatever we can. This pulls in a lot of new dependencies and most of them are probably unnecessary. Those cause a lot of work to maintain our binary LICENSE and NOTICE files and can cause runtime conflicts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org