You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by ka...@apache.org on 2015/08/06 04:14:37 UTC
[2/6] storm git commit: replacement of the double validator
replacement of the double validator
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/e7d89071
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/e7d89071
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/e7d89071
Branch: refs/heads/master
Commit: e7d890711fd72b3ff2eceddb5a090d24c6a89c98
Parents: db503a4
Author: Jerry <jerry@ubuntu.(none)>
Authored: Thu Jul 30 22:44:57 2015 -0700
Committer: Jerry <jerry@ubuntu.(none)>
Committed: Thu Jul 30 22:44:57 2015 -0700
----------------------------------------------------------------------
storm-core/src/jvm/backtype/storm/Config.java | 2 +-
.../src/jvm/backtype/storm/ConfigValidation.java | 19 +++++++++++++++++++
2 files changed, 20 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/e7d89071/storm-core/src/jvm/backtype/storm/Config.java
----------------------------------------------------------------------
diff --git a/storm-core/src/jvm/backtype/storm/Config.java b/storm-core/src/jvm/backtype/storm/Config.java
index 0dd489e..4628bd4 100644
--- a/storm-core/src/jvm/backtype/storm/Config.java
+++ b/storm-core/src/jvm/backtype/storm/Config.java
@@ -1194,7 +1194,7 @@ public class Config extends HashMap<String, Object> {
* The percentage of tuples to sample to produce stats for a task.
*/
public static final String TOPOLOGY_STATS_SAMPLE_RATE="topology.stats.sample.rate";
- public static final Object TOPOLOGY_STATS_SAMPLE_RATE_SCHEMA = Number.class;
+ public static final Object TOPOLOGY_STATS_SAMPLE_RATE_SCHEMA =ConfigValidation.PositiveNumberValidator;
/**
* The time period that builtin metrics data in bucketed into.
http://git-wip-us.apache.org/repos/asf/storm/blob/e7d89071/storm-core/src/jvm/backtype/storm/ConfigValidation.java
----------------------------------------------------------------------
diff --git a/storm-core/src/jvm/backtype/storm/ConfigValidation.java b/storm-core/src/jvm/backtype/storm/ConfigValidation.java
index a6e3057..7fd918b 100644
--- a/storm-core/src/jvm/backtype/storm/ConfigValidation.java
+++ b/storm-core/src/jvm/backtype/storm/ConfigValidation.java
@@ -254,6 +254,25 @@ public class ConfigValidation {
};
/**
+ * Validates a Positive Number
+ */
+ public static Object PositiveNumberValidator = new FieldValidator() {
+ @Override
+ public void validateField(String name, Object o) throws IllegalArgumentException {
+ if (o == null) {
+ // A null value is acceptable.
+ return;
+ }
+ if(o instanceof Number) {
+ if(((Number)o).doubleValue() > 0.0) {
+ return;
+ }
+ }
+ throw new IllegalArgumentException("Field " + name + " must be a Number");
+ }
+ };
+
+ /**
* Validates a power of 2.
*/
public static Object PowerOf2Validator = new FieldValidator() {