You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/25 04:11:22 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4615: Secondary storage: Allow store deletion after successful data migration
Pearl1594 opened a new pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615
### Description
This PR fixes the issue reported in :https://github.com/apache/cloudstack/issues/4613
This issue seems to have cropped up due to code revert that happened by commit - d864e9dc39b69e590e3df898a03a874a8173fcc6
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### How Has This Been Tested?
1. Migrate data from one image store to another
2. Attempt deleting the store from where all data objects we migrated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#discussion_r563572941
##########
File path: server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java
##########
@@ -522,6 +522,7 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso) {
sc.setParameters("store_id", storeId);
sc.setParameters("type", TemplateType.USER);
sc.setParameters("templateState", VirtualMachineTemplate.State.Active);
+ sc.setParameters("public", Boolean.FALSE);
Review comment:
@shwstppr Deletion of image stores will be prevented only if there are private user templates present on the respective store.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#discussion_r563569469
##########
File path: server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java
##########
@@ -522,6 +522,7 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso) {
sc.setParameters("store_id", storeId);
sc.setParameters("type", TemplateType.USER);
sc.setParameters("templateState", VirtualMachineTemplate.State.Active);
+ sc.setParameters("public", Boolean.FALSE);
Review comment:
@Pearl1594 why this change is needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-775939316
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766534072
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-775846123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-784017340
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2804
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-775846123
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783956283
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-775892946
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766527323
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-775804279
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-781322572
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783473028
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766527492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766534444
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#discussion_r563572941
##########
File path: server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java
##########
@@ -522,6 +522,7 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso) {
sc.setParameters("store_id", storeId);
sc.setParameters("type", TemplateType.USER);
sc.setParameters("templateState", VirtualMachineTemplate.State.Active);
+ sc.setParameters("public", Boolean.FALSE);
Review comment:
@shwstppr Deletion of image stores will be prevented only if there are private user templates present on the respective store.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-781323110
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-784115800
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-784116713
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783473705
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-775803850
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766544967
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-781370982
Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783518762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-775892548
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#discussion_r563569469
##########
File path: server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java
##########
@@ -522,6 +522,7 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso) {
sc.setParameters("store_id", storeId);
sc.setParameters("type", TemplateType.USER);
sc.setParameters("templateState", VirtualMachineTemplate.State.Active);
+ sc.setParameters("public", Boolean.FALSE);
Review comment:
@Pearl1594 why this change is needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766527492
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-784509946
<b>Trillian test result (tid-3604)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33931 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4615-t3604-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783664584
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2795
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766527323
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr removed a comment on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-775803850
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783518762
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2791
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-784110615
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2812
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org